[GRASS-dev] [GRASS GIS] #3083: allow single band processing with i.landsat.toar

[GRASS GIS]

#3083: allow single band processing with i.landsat.toar
--------------------------+-------------------------
  Reporter:  mankoff      |      Owner:  grass-dev@…
      Type:  enhancement  |     Status:  new
  Priority:  normal       |  Milestone:  7.4.0
 Component:  Raster       |    Version:  unspecified
Resolution:               |   Keywords:
       CPU:  Unspecified  |   Platform:  Unspecified
--------------------------+-------------------------

Comment (by mlennert):

 Replying to [comment:6 neteler]:
 > Can anyone please review the attachment (...a few lines)? Thanks

 IIUC, the 'band' parameter takes the number of the band in the list of
 bands. This might not be intuitive for people, who when asked which band
 might say '61' (or '80' for those landsat images where bands are numbered
 with two digits). At least this would need very clear documentation both
 in the parameter description and the man page.

 Also, I don't think this is explicit in our C submitting rules, but AFAIK,
 custom in GRASS has it that we do not use inline variable declarations. So
 the line

 {{{
 int i0, i1;
 }}}

 should come at the beginning with all the other declarations.

 Other than that, I agree with [https://lists.osgeo.org/pipermail/grass-
 dev/2017-May/085126.html Yann] that this is a quite trivial patch.

 I haven't tested, though.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3083#comment:7>
GRASS GIS <https://grass.osgeo.org>