[GRASS-dev] [release planning] 7.4.0

[Markus Neteler]

On Mon, Oct 2, 2017 at 3:48 PM, Martin Landa <landa.martin at gmail.com> wrote:
> 2017-10-02 15:01 GMT+02:00 Luca Delucchi <lucadeluge at gmail.com>:
>>> G7A:r.geomorphon
>>> G7A:r.object.geometry - +/- equivalent to v.to.db, but for raster
>>> objects: very useful for many other modules (notably OBIA)
>>> G7A:r.vect.stats - very simple, but nice functionality to have in core
>>> G7A:v.centerpoint - basic GIS functionality
>>> G7A:v.clip - very easy to use and expected GIS functionality without
>>> hassle of complicated commmands :-)
>>> G7A:v.profile - expected GIS functionality
>>>
>>
>> +1 for all the candidates
>
> please note, that new modules in trunk should have (ideally) tests. Martin

Right. As usual, especially the addon authors are kindly invited to
provide test cases.

Here some suggestions:

#######
r.geomorphon:
--> in the directory is an initial "test_rgeomorphon_NC.sh"

#######
r.object.geometry:  NC dataset
g.region raster=facility -p n=n+100 s=s-100 w=w-100 e=e+100
r.report facility unit=me | grep "facility"
 100%
|MAP: Rural area: Footprint of planned facility (facility in PERMANENT)       |
|1|facility footprint . . . . . . . . . . . . . . . . . . . . . . .| 13,130.00|

r.object.geometry input=facility separator=comma -m --q
cat,area,perimeter,compact_square,compact_circle,fd
1,13130.000000,478.000000,0.958880,1.176767,1.301241

#######
r.vect.stats:  NC dataset

eval `g.region raster=ncmask_500m -g`
v.random output=binary_random npoints=$cells
# assumption: in average one random point per cell

r.vect.stats input=binary_random output=nc_binary_random_sum method=sum
r.univar nc_binary_random_sum -g | grep "mean="
mean=1

#######
v.centerpoint:  too many warning still:

g.extension v.centerpoint
Fetching <v.centerpoint> from GRASS GIS Addons repository (be patient)...
Compiling...
areas.c: In function ‘areas_center’:
areas.c:165:7: warning: this ‘if’ clause does not guard...
[-Wmisleading-indentation]
       if (ICats->field[i] == layer)
       ^~
areas.c:167:4: note: ...this statement, but the latter is misleadingly
indented as if it were guarded by the ‘if’
    cat = ICats->cat[i];
    ^~~
areas.c:428:14: warning: declaration of ‘tot_w’ shadows a previous
local [-Wshadow]
  double *wb, tot_w;
              ^~~~~
areas.c:18:15: note: shadowed declaration is here
     double w, tot_w;
               ^~~~~
Installing...


#######
v.clip: NC dataset
https://grass.osgeo.org/grass72/manuals/addons/v.clip.html

A clip test could be made by counting points falling into a polygon,
similar to the example in the manual page.

#######
v.profile: NC dataset
https://grass.osgeo.org/grass72/manuals/addons/v.profile.html

A profile test could be made from the second example in the manual page.

Markus