[GRASS-dev] prefer GeoPackage over Shapefile

[Jachym Cepicky]

Hi Evan,
oh, thanks for the typo, fixed in my code ;-)

There is driver check in the code

https://svn.osgeo.org/grass/grass/trunk/vector/v.out.ogr/main.c

line 457

    for (i = 0; i < OGRGetDriverCount(); i++) {
        ...

I could probably commit, but before I do, I would like to get confirmed by
PSC, this is OK to GRASS community.

Jachym

P.S. I've prepared similar patch for QGIS for those, who are interested
https://github.com/qgis/QGIS/pull/5385


st 18. 10. 2017 v 14:36 odesílatel Even Rouault <even.rouault at spatialys.com>
napsal:

> On mercredi 18 octobre 2017 12:28:36 CEST Jachym Cepicky wrote:
> > Hi,
> >
> > I would like to submit following commit to GRASS GIS - master
> >
> > Index: vector/v.out.ogr/args.c
> > ===================================================================
> > --- vector/v.out.ogr/args.c (revision 71566)
> > +++ vector/v.out.ogr/args.c (working copy)
> > @@ -32,7 +32,7 @@
> >      options->format->type = TYPE_STRING;
> >      options->format->required = YES;
> >      options->format->multiple = NO;
> > -    options->format->answer = "ESRI_Shapefile";
> > +    options->format->answer = "DPKG";
> >      options->format->options = OGR_list_write_drivers();
> >      options->format->description = _("Data format to write");
> >
> >
> >
> > any objections?
> >
>
> I'm not a GRASS dev, but do I have a major objection... There's a typo in
> your
> patch ;-) Should be GPKG
>
> Joke aside, the SQLite dependency in GDAL builds is optional, so in theory
> you
> could have a GDAL build without SQLite/GPKG support. But this is really
> unlikely in practice as no sane packager would do that.  Perhaps checking
> if
> the GPKG driver is there would be safer, and if not fallback to good old
> shapefile.
>
> Even
>
>
> --
> Spatialys - Geospatial professional services
> http://www.spatialys.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/grass-dev/attachments/20171018/23a6ecf3/attachment.html>