[GRASS-dev] [GRASS GIS] #3537: Add functionalities –tmp-location and –no-clean

[GRASS GIS]

#3537: Add functionalities –tmp-location and –no-clean
-----------------------------+------------------------------------------
  Reporter:  radeknovotny94  |      Owner:  grass-dev@…
      Type:  enhancement     |     Status:  new
  Priority:  normal          |  Milestone:  7.6.0
 Component:  Startup         |    Version:  svn-trunk
Resolution:                  |   Keywords:  tmp-location, no-clean, exec
       CPU:  All             |   Platform:  All
-----------------------------+------------------------------------------

Comment (by radeknovotny94):

 Replying to [comment:4 wenzeslaus]:
 > Thank you for submitting a new version. Perhaps next time, leave there
 the old diff file, so we can refer to it if needed. About the diff itself:
 >
 > 1. I didn't catch it the first time, but it seems there was
 misunderstanding about what `--no-clean` should do. See the
 [wiki:GSoC/2018#Neweasy-to-useCLIandAPIforGRASSGIS wiki] again...
 Thank you for the better explanation, I tried to fix it in new patch.
 Please add your comments.
 > 2. Please provide documentation for this, ideally as part of the
 `grass7.html` file. This will make testing easier and addressing the use
 cases.
 I made the first version of the documentation and I am also waiting for
 your comments.

 > 3. It would be great of you come up with some more formal tests for it.
 It does not really fit into the `gunittest` tests but we can always start
 with a Bash script executing series of commands.
 I will make this Bash script in next days.

 > 4. Any particular reason to place `--no-clean` on the same line with
 `[[[GISDBASE/]LOCATION_NAME/]MAPSET]` in the help message? It should be
 probably with `--exec` or close to `-f`.
 It was because in my previous implementation `--no-clean` works for
 calling without `--exec` too. I changed it.

 > 5. In generally, please avoid unrelated whitespace changes in the
 patches/commits. Whitespace and other PEP8 things can and should be
 changed, but in separate commits. See your lines 375 and 403 (Trac view
 numbering) in your diff.

 Thanks, I know it, I was more attentive about it this time.

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/3537#comment:5>
GRASS GIS <https://grass.osgeo.org>