[GRASS-dev] [GRASS-SVN] r72650 - grass/trunk/scripts/i.spectral

[Maris Nartiss]

Hello Moritz,
if subgroups are removed, it will be necessary to update all i.
modules to follow some kind of new workflow. For the current state of
GRASS, subgroups are crucial.
I'm adding output of i.group on my system. As you can see, output of
i.spectral on the output of i.maxlik is nonsense and thus should be
avoided. Also I like to have one group for whole scene and switch
between RGB (visible) and RGBI (VNIR) bands as needed.
IMHO subgroups should be implemented in a way as in i.spectral – if no
subgroup is provided, all maps from the group are used. Thus subgroup
usage would be opt-in for those who understand how to use them.
I somehow fail to see what kind of problem will be solved by removing
subgroup functionality.

Māris.

> i.group -l Mai05
group <Mai05> references the following raster maps
-------------
<B02COR_20170505T094031 at piemers>    <B03COR_20170505T094031 at piemers>
<B04COR_20170505T094031 at piemers>    <B08COR_20170505T094031 at piemers>
<Mai05_clusters at piemers>            <Mai05_5clusters at piemers>
<Mai05_clusters3 at piemers>           <Mai05_clusters5 at piemers>
<Mai05_clusters6 at piemers>           <Mai05_allsigs_MLC at piemers>
-------------

> i.group -ls Mai05
group <Mai05> references the following subgroups
-------------
all    rgb
-------------

> i.group -ls Mai05 subgroup=all
subgroup <all> of group <Mai05> references the following raster maps
-------------
<B02COR_20170505T094031 at piemers>    <B04COR_20170505T094031 at piemers>
<B03COR_20170505T094031 at piemers>    <B08COR_20170505T094031 at piemers>
-------------

> i.group -ls Mai05 subgroup=rgb
subgroup <rgb> of group <Mai05> references the following raster maps
-------------
<B02COR_20170505T094031 at piemers>    <B04COR_20170505T094031 at piemers>
<B03COR_20170505T094031 at piemers>
-------------

2018-04-26 15:46 GMT+03:00 Moritz Lennert <mlennert at club.worldonline.be>:
> Hi Maris,
>
> Could you explain your motivation behind this commit ? There have been
> discussions on and off (latest at the code sprint in Bonn) about the
> possibility to actually get rid of the notion of subgroups altogether. For
> that discussion, it would be interesting to know the actual patterns of use
> of subgroups.
>
> Moritz
>
>
>
> On 26/04/18 13:19, svn_grass at osgeo.org wrote:
>>
>> Author: marisn
>> Date: 2018-04-26 04:19:33 -0700 (Thu, 26 Apr 2018)
>> New Revision: 72650
>>
>> Modified:
>>     grass/trunk/scripts/i.spectral/i.spectral.py
>> Log:
>> i.spectral: Add subgroup option
>>
>>
>> Modified: grass/trunk/scripts/i.spectral/i.spectral.py
>> ===================================================================
>> --- grass/trunk/scripts/i.spectral/i.spectral.py        2018-04-26
>> 10:20:18 UTC (rev 72649)
>> +++ grass/trunk/scripts/i.spectral/i.spectral.py        2018-04-26
>> 11:19:33 UTC (rev 72650)
>> @@ -36,6 +36,10 @@
>>   #% required : no
>>   #% guisection: Input
>>   #%end
>> +#%option G_OPT_I_SUBGROUP
>> +#% required : no
>> +#% guisection: Input
>> +#%end
>>   #%option G_OPT_R_INPUTS
>>   #% key: raster
>>   #% required : no
>> @@ -198,6 +202,7 @@
>>     def main():
>>       group = options['group']
>> +    subgroup = options['subgroup']
>>       raster = options['raster']
>>       output = options['output']
>>       coords = options['coordinates']
>> @@ -226,7 +231,10 @@
>>       # get data from group listing and set the x-axis labels
>>       if group:
>>           # Parse the group list output
>> -        s = gcore.read_command('i.group', flags='g', group=group,
>> quiet=True)
>> +        if subgroup:
>> +            s = gcore.read_command('i.group', flags='g', group=group,
>> subgroup=subgroup, quiet=True)
>> +        else:
>> +            s = gcore.read_command('i.group', flags='g', group=group,
>> quiet=True)
>>           rastermaps = s.splitlines()
>>       else:
>>           # get data from list of files and set the x-axis labels
>>
>> _______________________________________________
>> grass-commit mailing list
>> grass-commit at lists.osgeo.org
>> https://lists.osgeo.org/mailman/listinfo/grass-commit
>>
>
>