[GRASS-dev] Regarding testing

[Luca Delucchi]

On 8 May 2018 at 07:39, Sanjeet <edu.sanjeet at gmail.com> wrote:
>
> Hi Anna,
>

Hi,

> I made some minor changes in 'utils.py' in lib/python/script and
> 'test_utils.py' in its testsuite.
> https://github.com/sanjeetbhatti/FullSupportPython3/blob/master/patch.diff
>
> The Python 3's bytes cannot contain ASCII literal characters,
> therefore I can't seem to test it as such, I encoded it first before
> checking for an assertion, which I am not sure is a correct way to do
> so as we are ensuring that we do not pass any bytes with ASCII literal
> characters.

could be this a problem with languages using strange accent mark?
We had and have problem with some languages in translations

> Same thing is in test_start_command_functions.py.
> Moreover, I generalized the encode and decode functions by using
> string conversion for int and float values.
>
> Please let me know if this is the correct way to go about it.
>

It seems correct to me, but please Anna answer

> Thanks
> --
> Sanjeet Bhatti



-- 
ciao
Luca

www.lucadelu.org