[GRASS-dev] Regarding testing
edu.sanjeet at gmail.com
Wed May 23 08:10:49 PDT 2018
On Mon, May 21, 2018 at 8:03 PM, Anna Petrášová <kratochanna at gmail.com> wrote:
> Hi Sanjeet and others,
> We discussed further changes in this library regarding unicode/bytes
> handling with Vaclav and collected ideas here . Basically, we need
> to adjust many functions to accept and return unicode ('str' in
> Python3), otherwise the functions won't behave as expected when used
> by Python 3 users. For Popen wrapper functions (read_command,
> run_command, ...) we suggest to use new encoding parameter (similar to
> Popen in Python3.6) allowing to switch the behavior for fine control,
> with using unicode by default (to work as expected by Python 3 users).
> There will be problems because it's not garbage in garbage out as it
> used to be, so something encoded on Windows won't be read correctly on
> Linux. However this is our current idea, we can discuss it further.
> So, Sanjeet, let me know if it makes sense to you and try to implement
> the changes where necessary (starting with core.py). It would be good
> to write more tests during the process.
I uploaded a small patch (on the ticket) last night regarding these
changes in the core.py.
Let me know if I am doing it correctly.
More information about the grass-dev