[GRASS-dev] [GRASS GIS] #3797: r.horizon suffix gets messed up in multi-direction mode
GRASS GIS
trac at osgeo.org
Sun Mar 24 11:40:44 PDT 2019
#3797: r.horizon suffix gets messed up in multi-direction mode
--------------------------+-------------------------
Reporter: sbl | Owner: grass-dev@…
Type: defect | Status: closed
Priority: normal | Milestone: 7.8.0
Component: Raster | Version: svn-trunk
Resolution: fixed | Keywords: r.horizon
CPU: Unspecified | Platform: Linux
--------------------------+-------------------------
Comment (by mmetz):
Replying to [comment:4 sbl]:
> Very good. Then I take the liberty to close this ticket...
Hi Stefan, you are the original reporter of this ticket, therefore you
have IMHO the right to close the ticket. Someone else submitting a fix can
also close the ticket if this person is really confident that the issue
has been fixed.
In this case, my system behaved differently: the wrong output on
http://fatra.cnr.ncsu.edu/grassgistests/ was
"test_horizon_output_from_elevation_%03", but on my system it was
"test_horizon_output_from_elevation_", i.e. my system behaved differently.
With my fix, my system produced correct output, and I was quite but not
really sure that my fix works on other systems as well. Thus waiting for
confirmation by the original reporter that the fix is working on other
systems as well.
This particular bug and the related fix passed CI, thus CI is in this case
not good enough, only the test for r.horizon. Another point to
1. get the testsuite all green
2. make CI run the testsuite and let CI fail if the testsuite is not all
green
--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3797#comment:5>
GRASS GIS <https://grass.osgeo.org>
More information about the grass-dev
mailing list