[GRASS-dev] Pull requests for new addon 'r.zonal.classes'

Taïs tgrippa at ulb.ac.be
Mon Sep 23 07:09:33 PDT 2019


Hi Markus,

Thanks for the review I committed all the changes you suggested + fix 
the line length on the html file.

I think it's ready to be merge.

Cheers

Le 22/09/19 à 19:10, Markus Neteler a écrit :
> Dear Taïs,
>
> On Wed, Sep 11, 2019 at 11:28 AM Taïs Grippa <tgrippa at ulb.ac.be> wrote:
>> Dear GRASS developers,
>>
>> For your information, I just made a pull request on the grass-addon repository:
>>
>> https://github.com/OSGeo/grass-addons/pull/28
>>
>> This addon computes class proportions and majority class of a "cover layer" (e.g., a land cover map) according to how it intersects with areas/objects in a "base layer". This function is similar to what r.stats.zonal performs, but is intended to be used on integer values raster (CELL type) instead.
> Nice, thanks for your contribution.
>
> I made a minor review (see GH) with some editing.
>
> One wish:
> As per style guide (https://trac.osgeo.org/grass/wiki/Submitting/Docs)
> long lines in the HTML manual should be avoided,
> if possible, please reformat the file.
>
> thanks for your work,
>
> Markus
>
-------------- section suivante --------------
Une pièce jointe autre que texte a été nettoyée...
Nom: tgrippa.vcf
Type: text/x-vcard
Taille: 4 octets
Desc: non disponible
URL: <http://lists.osgeo.org/pipermail/grass-dev/attachments/20190923/fbb541ad/attachment.vcf>


More information about the grass-dev mailing list