<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jan 1, 2008, at 3:13 AM, <a href="mailto:grass-dev-request@lists.osgeo.org">grass-dev-request@lists.osgeo.org</a> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><p style="margin: 0.0px 0.0px 0.0px 0.0px; font: 12.0px Helvetica; min-height: 14.0px"><br></p> <blockquote type="cite"><p style="margin: 0.0px 0.0px 0.0px 10.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica">#12: gis.m->Help->About system doesn't work (launches another gis.m instance)</font></p> <p style="margin: 0.0px 0.0px 0.0px 10.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica">----------------------+-----------------------------------------------------</font></p> <p style="margin: 0.0px 0.0px 0.0px 10.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica"><span class="Apple-converted-space"> </span>Reporter:<span class="Apple-converted-space"> </span>neteler<span class="Apple-converted-space"> </span>| <span class="Apple-converted-space"> </span>Owner:<span class="Apple-converted-space"> </span><a href="mailto:grass-dev@lists.osgeo.org">grass-dev@lists.osgeo.org</a></font></p> <p style="margin: 0.0px 0.0px 0.0px 10.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica"><span class="Apple-converted-space"> </span>Type:<span class="Apple-converted-space"> </span>defect <span class="Apple-converted-space"> </span>|<span class="Apple-converted-space"> </span>Status:<span class="Apple-converted-space"> </span>new <span class="Apple-converted-space"> </span></font></p> <p style="margin: 0.0px 0.0px 0.0px 10.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica"><span class="Apple-converted-space"> </span>Priority:<span class="Apple-converted-space"> </span>major<span class="Apple-converted-space"> </span>| <span class="Apple-converted-space"> </span>Milestone:<span class="Apple-converted-space"> </span>6.3.0 <span class="Apple-converted-space"> </span></font></p> <p style="margin: 0.0px 0.0px 0.0px 10.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica"><span class="Apple-converted-space"> </span>Component:<span class="Apple-converted-space"> </span>default<span class="Apple-converted-space"> </span>| <span class="Apple-converted-space"> </span>Version:<span class="Apple-converted-space"> </span>unspecified <span class="Apple-converted-space"> </span></font></p> <p style="margin: 0.0px 0.0px 0.0px 10.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica">Resolution: <span class="Apple-converted-space"> </span>|<span class="Apple-converted-space"> </span>Keywords:<span class="Apple-converted-space"> </span></font></p> <p style="margin: 0.0px 0.0px 0.0px 10.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica">----------------------+-----------------------------------------------------</font></p> <p style="margin: 0.0px 0.0px 0.0px 10.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica">Comment (by cmbarton):</font></p> <p style="margin: 0.0px 0.0px 0.0px 10.0px; font: 12.0px Helvetica; min-height: 14.0px"><br></p> <p style="margin: 0.0px 0.0px 0.0px 10.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica"><span class="Apple-converted-space"> </span>Replying to [ticket:12 neteler]:</font></p> <blockquote type="cite"><p style="margin: 0.0px 0.0px 0.0px 20.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica">Clicking on 'About System' within the gis.m Help menu launches a new set</font></p> </blockquote><p style="margin: 0.0px 0.0px 0.0px 10.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica"><span class="Apple-converted-space"> </span>of gis.m windows instead of opening a tcl/tk window with system</font></p> <p style="margin: 0.0px 0.0px 0.0px 10.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica"><span class="Apple-converted-space"> </span>parameters. The newly created gis manager toolbar says "Tk System</font></p> <p style="margin: 0.0px 0.0px 0.0px 10.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica"><span class="Apple-converted-space"> </span>Information".</font></p> <blockquote type="cite"><p style="margin: 0.0px 0.0px 0.0px 20.0px; font: 12.0px Helvetica; min-height: 14.0px"><br></p> <p style="margin: 0.0px 0.0px 0.0px 20.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica">PS: moved here from</font></p> </blockquote><p style="margin: 0.0px 0.0px 0.0px 10.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica"><span class="Apple-converted-space"> </span><a href="http://wald.intevation.org/tracker/?func=detail&atid=204&aid=553&group_id=21">http://wald.intevation.org/tracker/?func=detail&atid=204&aid=553&group_id=21</a></font></p> <p style="margin: 0.0px 0.0px 0.0px 10.0px; font: 12.0px Helvetica; min-height: 14.0px"><br></p> <p style="margin: 0.0px 0.0px 0.0px 10.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica"><span class="Apple-converted-space"> </span>Is this function worth the trouble of trying to fix?</font></p> </blockquote><p style="margin: 0.0px 0.0px 0.0px 0.0px; font: 12.0px Helvetica; min-height: 14.0px"><br></p> <p style="margin: 0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica">This is just a symptom of a larger problem, namely that the Gm::errmsg</font></p> <p style="margin: 0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica">procedure is defined in gm.tcl, which cannot be "source"d (because</font></p> <p style="margin: 0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica">doing so will "run" gis.m).</font></p> <p style="margin: 0.0px 0.0px 0.0px 0.0px; font: 12.0px Helvetica; min-height: 14.0px"><br></p> <p style="margin: 0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica">Gm::errmsg belongs in a "library", i.e. a Tcl source file which can be</font></p> <p style="margin: 0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica">"source"d from other Tcl source files.</font></p> <p style="margin: 0.0px 0.0px 0.0px 0.0px; font: 12.0px Helvetica; min-height: 14.0px"><br></p> <p style="margin: 0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica">Also: gm.tcl calls Gm::errmsg from top-level code at the beginning of</font></p> <p style="margin: 0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica">the file (the code which copies various g.gisenv settings into $env),</font></p> <p style="margin: 0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica">although the procedure isn't actually defined until much later in the</font></p> <p style="margin: 0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica">file. If any of those "catch" statements actually catch an error, the</font></p> <p style="margin: 0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" size="3" style="font: 12.0px Helvetica">handler will throw an error due to Gm::errmsg being undefined.</font></p> </blockquote><br></div><div>Making a library and moving Gm::errmsg to it is pretty easy to fix (just a LOT of find/replace throughout the GUI code). Anything else that you know of should come out of gm.tcl and into such a library?</div><div><br class="webkit-block-placeholder"></div><div>However, making the 'get system info' function work is more trouble. As I said in the rest of the post, it's very old code. Is it worth bothering with to have the GUI launch a window with a bit of minimal system info?</div><div><br class="webkit-block-placeholder"></div><div>Michael</div><div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font face="Helvetica" size="3" style="font: normal normal normal 12px/normal Helvetica; ">____________________</font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font face="Helvetica" size="3" style="font: normal normal normal 12px/normal Helvetica; ">C. Michael Barton, Professor of Anthropology</font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Director of Graduate Studies</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font face="Helvetica" size="3" style="font: normal normal normal 12px/normal Helvetica; ">School of Human Evolution & Social Change</font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Center for Social Dynamics & Complexity</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font face="Helvetica" size="3" style="font: normal normal normal 12px/normal Helvetica; ">Arizona State University</font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 12px/normal Helvetica; min-height: 14px; "><br></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font face="Helvetica" size="3" style="font: normal normal normal 12px/normal Helvetica; ">Phone: 480-965-6262</font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font face="Helvetica" size="3" style="font: normal normal normal 12px/normal Helvetica; ">Fax: 480-965-7671</font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font face="Helvetica" size="3" style="font: normal normal normal 12px/normal Helvetica; ">www: <<a href="http://www.public.asu.edu/~cmbarton">www.public.asu.edu/~cmbarton</a>></font></div></div><br class="Apple-interchange-newline"></div></body></html>