<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Dec 20, 2014 at 12:20 PM, Markus Neteler <span dir="ltr"><<a href="mailto:neteler@osgeo.org" target="_blank">neteler@osgeo.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi devs,<br>
<br>
I spent some time today to check all failing test in the test suite:<br>
<a href="http://fatra.cnr.ncsu.edu/grassgistests/summary_report/index.html" target="_blank">http://fatra.cnr.ncsu.edu/grassgistests/summary_report/index.html</a><br>
<br>
<br>
#### NO IDEA problem<br>
<a href="http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_nc_spm_08_grass7_nc/raster/r.profile/test_profile_ncspm/index.html" target="_blank">http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_nc_spm_08_grass7_nc/raster/r.profile/test_profile_ncspm/index.html</a><br>
--> I don't know that the issue is<br>
<br></blockquote><div>No idea here neither. <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
###### JUNK REMAINED issue:<br>
<br>
<a href="http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_nc_spm_08_grass7_nc/raster/r.in.poly/test_rinpoly/index.html" target="_blank">http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_nc_spm_08_grass7_nc/raster/r.in.poly/test_rinpoly/index.html</a><br>
--> ERROR: option <output>: <test_rinpoly> exists.<br>
<br>
Some overwrite flag needed?<br>
<br></blockquote><div>overwrite flag should not be used with the tests.<br><br>Currently the test should try to clean up after itself using standard means. This is advantageous in case of running in the user's current mapset. This might be somehow changes in the future, e.g. some API introduced, but generally we probably will not get rid of it.<br><br>In case of automatic running of all tests, each test file has it's own mapset which is deleted afterwards, so no junk should remain.<br><br></div><div>This is might caused by two different test methods or test case classes using the maps with the same names. This should be avoided.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
But when I run it locally here:<br>
<br>
Traceback (most recent call last):<br>
File "raster/r.in.poly/testsuite/test_rinpoly.py", line 107, in testLabels<br>
msg="Labels do not match")<br>
AssertionError: Labels do not match<br>
'-8\t\n3\tlabel2\n10.01\tlabel1' != '-8\t\n3\tlabel2\n10.01'<br>
<br></blockquote><div>The order of test execution is not defined (in test file driven by Python unittest) and can be different each time. Test methods should not depend on each other.<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
###### MISSING MAPS problems (in the piemonte location the names<br>
differ, so they should be locally renamed):<br>
<br>
<a href="http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_piemonte_utm32_wgs84_grass7_stdmaps/lib/python/pygrass/vector/test_geometry/index.html" target="_blank">http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_piemonte_utm32_wgs84_grass7_stdmaps/lib/python/pygrass/vector/test_geometry/index.html</a><br>
--> "roadmajor" does not exist in the server dataset<br>
<br>
<a href="http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_piemonte_utm32_wgs84_grass7_stdmaps/lib/python/pygrass/vector/test_vector/index.html" target="_blank">http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_piemonte_utm32_wgs84_grass7_stdmaps/lib/python/pygrass/vector/test_vector/index.html</a><br>
--> OpenError: Map <points_of_interest> not found.<br>
<br>
<a href="http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_piemonte_utm32_wgs84_grass7_stdmaps/lib/python/pygrass/vector/test_doctests/index.html" target="_blank">http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_piemonte_utm32_wgs84_grass7_stdmaps/lib/python/pygrass/vector/test_doctests/index.html</a><br>
--> WARNING: <census> not found<br>
<br>
<a href="http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_piemonte_utm32_wgs84_grass7_stdmaps/vector/v.what/test_vwhat_ncspm/index.html" target="_blank">http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_piemonte_utm32_wgs84_grass7_stdmaps/vector/v.what/test_vwhat_ncspm/index.html</a><br>
--> ERROR: Vector map <bridges> not found<br>
<br>
<a href="http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_piemonte_utm32_wgs84_grass7_stdmaps/raster/r.profile/test_profile_ncspm/index.html" target="_blank">http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_piemonte_utm32_wgs84_grass7_stdmaps/raster/r.profile/test_profile_ncspm/index.html</a><br>
<a href="http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_piemonte_utm32_wgs84_grass7_stdmaps/raster/r.slope.aspect/test_r_slope_aspect/index.html" target="_blank">http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_piemonte_utm32_wgs84_grass7_stdmaps/raster/r.slope.aspect/test_r_slope_aspect/index.html</a><br>
--> ERROR: Raster map <elevation> not found<br>
<br></blockquote><div>I'm afraid, I don't want to maintain my own version of the dataset, so I will wait for the official one or at least the official table for renaming.<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
###### MISSING MAPS problems NC dataset:<br>
<a href="http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_nc_spm_08_grass7_nc/lib/python/pygrass/vector/test_vector/index.html" target="_blank">http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_nc_spm_08_grass7_nc/lib/python/pygrass/vector/test_vector/index.html</a><br>
--> OpenError: Map <points_of_interest> not found.<br>
<br>
<a href="http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_nc_spm_08_grass7_nc/lib/python/pygrass/vector/test_doctests/index.html" target="_blank">http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-12-20-08-00/report_for_nc_spm_08_grass7_nc/lib/python/pygrass/vector/test_doctests/index.html</a><br>
--> WARNING: <census> not found<br>
<br></blockquote><div>Unfortunately, same as above and the following is blocker for this:<br></div><div> </div><div><a href="http://lists.osgeo.org/pipermail/grass-dev/2014-December/072600.html">http://lists.osgeo.org/pipermail/grass-dev/2014-December/072600.html</a> <br></div><div><a href="http://osgeo-org.1560.x6.nabble.com/Heading-towards-unified-dataset-td5165053.html">http://osgeo-org.1560.x6.nabble.com/Heading-towards-unified-dataset-td5165053.html</a><br><a href="http://comments.gmane.org/gmane.comp.gis.grass.devel/60326">http://comments.gmane.org/gmane.comp.gis.grass.devel/60326</a><br><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
####### DESIGN wish:<br>
<br>
Each test page contains a title like this:<br>
./vector/v.what – test_vwhat_layers<br>
<br>
Could please the path to the file be added as<br>
Testsuite: vector/v.what/testsuite/test_vwhat_layers.py<br>
<br>
for easy copy-pasting in the local computer? Would be more joy for<br>
fixing tests... thanks.<br>
<br></blockquote><div>I'm all for joy. Done in r63795 in a messy way for now. It is part of the table at the beginning. However, note that you are also interested in the files in the tested directory and it would be more challenging to add these. Another ideas are links to Trac tickets, revisions or files.<br><br></div><div>Create tickets if you have some concrete ideas and feel free to discuss the incomplete ones. However, I cannot promise I can work on that but perhaps somebody else could.<br></div><div><br></div><div>Vaclav<br></div><div><br><a href="http://trac.osgeo.org/grass/changeset/63795">http://trac.osgeo.org/grass/changeset/63795</a><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
All fixes I have backported as well.<br>
<br>
Markus<br>
_______________________________________________<br>
grass-dev mailing list<br>
<a href="mailto:grass-dev@lists.osgeo.org">grass-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/grass-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/grass-dev</a></blockquote></div><br></div></div>