<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 23, 2017 at 9:22 AM, Moritz Lennert <span dir="ltr"><<a href="mailto:mlennert@club.worldonline.be" target="_blank">mlennert@club.worldonline.be</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Rashad,<span class=""><br>
<br>
On 22/01/17 11:00, Rashad Kanavath wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I fixed all the points from last mail.<br>
</blockquote>
<br></span>
Wonderful !<br>
<br>
It seems that you missed one point (see in the ticket #3142/#3247).<br>
<br>
Thank you so much for this great job !<br></blockquote><div><br></div><div>Thanks. Sorry that I missed it. I will push a fix for both and update the tracker too. <br><br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Moritz<br>
<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br>
On Fri, Jan 6, 2017 at 9:28 AM, Markus Metz<br></span>
<<a href="mailto:markus.metz.giswork@gmail.com" target="_blank">markus.metz.giswork@gmail.com</a> <mailto:<a href="mailto:markus.metz.giswork@gmail.com" target="_blank">markus.metz.giswork@gm<wbr>ail.com</a>>><span class=""><br>
wrote:<br>
<br>
<br>
<br>
On Tue, Dec 27, 2016 at 9:05 PM, Rashad Kanavath<br></span><div><div class="h5">
<<a href="mailto:mohammedrashadkm@gmail.com" target="_blank">mohammedrashadkm@gmail.com</a> <mailto:<a href="mailto:mohammedrashadkm@gmail.com" target="_blank">mohammedrashadkm@gmail<wbr>.com</a>>> wrote:<br>
<br>
<br>
<br>
I had pushed a updated version of code:<br>
<br>
Done:<br>
1. input is a imagery group from i.group (handles all raster in<br>
the group)<br>
2. removed rgb2lab conversion<br>
3. implementation of id output map<br>
4. replaced fmin with MIN and MAX macro<br>
5. compactness is a new option to module? (default is 20 from paper)<br>
<br>
Wonderful, thanks!<br>
<br>
<br>
TODO:<br>
1. add option for SLICO<br>
2. use segment library to avoid memory limitation when reading<br>
raster data<br>
<br>
Hope this works now. Let me know If I missed something else.<br>
<br>
Code clean-up:<br>
- please use tools/grass_indent.sh<br>
- move variable declarations to the beginning of a code block<br>
- convert C++ style comments to C style comments<br>
- line 155<br>
int sz = nrows * ncols;<br>
<br>
can cause integer overflow. Use off_t (large raster maps can only be<br>
handled with LFS, i.e. off_t being a 64bit integer).<br>
<br>
- fix L157: must be<br>
int **pdata;<br>
<br>
pdata = G_malloc(sizeof(int) * group_ref.nfiles);<br>
<br>
- Lines 317,318 are correct, line 320 is wrong<br>
<br>
<br>
And...<br>
<br>
Happy New Year to all :-)<br>
<br>
Happy new year to you too!<br>
<br>
Markus M<br>
<br>
<br>
<br>
On Thu, Dec 22, 2016 at 10:12 AM, Markus Neteler<br></div></div><span class="">
<<a href="mailto:neteler@osgeo.org" target="_blank">neteler@osgeo.org</a> <mailto:<a href="mailto:neteler@osgeo.org" target="_blank">neteler@osgeo.org</a>>> wrote:<br>
<br>
On Thu, Dec 22, 2016 at 12:01 AM, Markus Metz<br>
<<a href="mailto:markus.metz.giswork@gmail.com" target="_blank">markus.metz.giswork@gmail.com</a><br></span><span class="">
<mailto:<a href="mailto:markus.metz.giswork@gmail.com" target="_blank">markus.metz.giswork@gm<wbr>ail.com</a>>> wrote:<br>
...<br>
> Adding<br>
><br>
> #undef MIN<br>
> #define MIN(a,b) ((a) < (b) ? (a) : (b))<br>
><br>
> as in other GRASS modules is a nice solution to keep things simple and<br>
> portable.<br>
<br>
... how about a adding this and similar definitions to gis.h?<br>
<br>
markusN<br>
______________________________<wbr>_________________<br>
grass-dev mailing list<br></span>
<a href="mailto:grass-dev@lists.osgeo.org" target="_blank">grass-dev@lists.osgeo.org</a> <mailto:<a href="mailto:grass-dev@lists.osgeo.org" target="_blank">grass-dev@lists.osgeo.<wbr>org</a>><br>
<a href="http://lists.osgeo.org/mailman/listinfo/grass-dev" rel="noreferrer" target="_blank">http://lists.osgeo.org/mailman<wbr>/listinfo/grass-dev</a><span class=""><br>
<<a href="http://lists.osgeo.org/mailman/listinfo/grass-dev" rel="noreferrer" target="_blank">http://lists.osgeo.org/mailma<wbr>n/listinfo/grass-dev</a>><br>
<br>
<br>
<br>
<br>
--<br>
Regards,<br>
Rashad<br>
<br>
<br>
<br>
<br>
<br>
--<br>
Regards,<br>
Rashad<br>
</span></blockquote>
<br>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div><font face="arial, helvetica, sans-serif">Regards,<br> Rashad</font></div></div>
</div></div>