[GRASS-QA] SOCCER LAB GRASS QA: 1 clones ( do_astar.c ) 0 monsters and 2 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello brad,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.watershed/seg/do_astar.c functions


do_astar (Begins at: 5 Ends at: 65)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      22 |       |      OK |
LOC:          |      61 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

add_pt (Begins at: 68 Ends at: 116)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |      11 |       |      OK |
LOC:          |      49 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

get_slope (Begins at: 119 Ends at: 132)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       0 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

replace (Begins at: 135 Ends at: 158)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 1 potentially cloned functions:
  get_slope

In raster/r.watershed/seg/do_astar.c clones of  get_slope are:
	raster/r.watershed/ram/do_astar.c  get_slope


__________________________________________

Threshold GRASS6 key metrics values at 2006-04-25 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      78 |
LOC:                    40 |       182 |     256 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html