[GRASS-QA] GRASS QA: glynn | ./grass6/display/drivers/lib/pad.c |8 clones ( clip.c Color.c command.c connect_sock.c Erase.c Get_t_box.c pad.c )| 0 monsters | 0 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


display/drivers/lib/pad.c functions


free_item (Begins at: 11 Ends at: 27)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      17 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

new_item (Begins at: 29 Ends at: 51)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      23 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

remove_value (Begins at: 53 Ends at: 72)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      20 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

append_item (Begins at: 74 Ends at: 116)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      43 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

delete_item (Begins at: 118 Ends at: 138)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      21 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

find_item (Begins at: 140 Ends at: 149)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

pad_list (Begins at: 151 Ends at: 154)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

delink_pad (Begins at: 156 Ends at: 170)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

create_pad (Begins at: 172 Ends at: 192)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      21 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

delete_pad (Begins at: 194 Ends at: 212)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

find_pad (Begins at: 214 Ends at: 222)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

invent_pad (Begins at: 224 Ends at: 233)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 8 potentially cloned functions:
  remove_value  append_item  create_pad  delink_pad  delete_pad  delete_item  find_item  new_item

In display/drivers/lib/pad.c clones of  delink_pad are:
	lib/driver/pad.c  delink_pad

In display/drivers/lib/pad.c clones of  append_item are:
	lib/driver/pad.c  append_item

In display/drivers/lib/pad.c clones of  new_item are:
	lib/driver/pad.c  new_item

In display/drivers/lib/pad.c clones of  create_pad are:
	lib/driver/pad.c  create_pad

In display/drivers/lib/pad.c clones of  delete_pad are:
	lib/driver/pad.c  delete_pad

In display/drivers/lib/pad.c clones of  find_item are:
	lib/driver/pad.c  find_item

In display/drivers/lib/pad.c clones of  remove_value are:
	lib/driver/pad.c  remove_value

In display/drivers/lib/pad.c clones of  delete_item are:
	lib/driver/pad.c  delete_item


__________________________________________

Threshold GRASS6 key metrics values at 2006-08-01 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    39 |       179 |     251 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html