[GRASS-QA] GRASS QA: glynn | ./grass6/display/drivers/lib/connect_sock.c |3 clones ( clip.c Color.c command.c connect_sock.c )| 0 monsters | 0 warnings

cvs at proxy.soccerlab.polymtl.ca cvs at proxy.soccerlab.polymtl.ca
Tue Aug 1 18:10:48 EDT 2006


Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


display/drivers/lib/connect_sock.c functions


get_connection_sock (Begins at: 18 Ends at: 55)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      23 |       |      OK |
LOC:          |      38 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

prepare_connection_sock (Begins at: 58 Ends at: 76)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

check_connection (Begins at: 79 Ends at: 100)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 3 potentially cloned functions:
  prepare_connection_sock  check_connection  get_connection_sock

In display/drivers/lib/connect_sock.c clones of  get_connection_sock are:
	lib/driver/connect_sock.c  get_connection_sock

In display/drivers/lib/connect_sock.c clones of  check_connection are:
	lib/driver/connect_sock.c  check_connection

In display/drivers/lib/connect_sock.c clones of  prepare_connection_sock are:
	lib/driver/connect_sock.c  prepare_connection_sock


__________________________________________

Threshold GRASS6 key metrics values at 2006-08-01 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    39 |       179 |     251 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list