[GRASS-QA] GRASS QA: soeren | ./grass6/raster/r.le/r.le.pixel/driver.c |no clones | 5 monsters | 3 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello soeren,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.le/r.le.pixel/driver.c functions


texture_fore (Begins at: 47 Ends at: 140)
--------------+---------+-------+---------+
Complexity:   |      13 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |      41 |     * |         |
LOC:          |      94 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

mv_driver (Begins at: 147 Ends at: 1072)
--------------+---------+-------+---------+
Complexity:   |     167 |   *** | MONSTER |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |     356 |   *** | MONSTER |
LOC:          |     926 |   *** | MONSTER |
--------------+---------+-------+---------+
3 metric are OUT OF RANGE!

set_colors (Begins at: 1074 Ends at: 1091)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

fopen0 (Begins at: 1093 Ends at: 1108)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

fopen1 (Begins at: 1116 Ends at: 1133)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      10 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

fopen2 (Begins at: 1139 Ends at: 1155)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       9 |       |      OK |
LOC:          |      17 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

fopen3 (Begins at: 1161 Ends at: 1177)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       9 |       |      OK |
LOC:          |      17 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

meter2 (Begins at: 1185 Ends at: 1224)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       9 |       |      OK |
LOC:          |      40 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

read_mwind (Begins at: 1230 Ends at: 1259)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      12 |       |      OK |
LOC:          |      30 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

unit_driver (Begins at: 1265 Ends at: 1499)
--------------+---------+-------+---------+
Complexity:   |      42 |   *** | MONSTER |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |      69 |    ** | Warning |
LOC:          |     235 |    ** | Warning |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

run_clip (Begins at: 1501 Ends at: 1559)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |      10 |   *** | MONSTER |
CalledNBR:    |      12 |       |      OK |
LOC:          |      59 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

whole_reg_driver (Begins at: 1561 Ends at: 1752)
--------------+---------+-------+---------+
Complexity:   |      34 |    ** | Warning |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |      35 |     * |         |
LOC:          |     192 |    ** | Warning |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code

get_rich_whole (Begins at: 1754 Ends at: 1779)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      26 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-08-14 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      80 |
LOC:                    39 |       179 |     251 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html