[GRASS-QA] GRASS QA: markus | ./grass6/raster/r.lake/main.c |no clones | 3 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.lake/main.c functions


save_map (Begins at: 41 Ends at: 83)
--------------+---------+-------+---------+
Complexity:   |       9 |       |      OK |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |      14 |       |      OK |
LOC:          |      43 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

is_near_water (Begins at: 86 Ends at: 103)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

load_window_values (Begins at: 106 Ends at: 138)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       0 |       |      OK |
LOC:          |      33 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

main (Begins at: 140 Ends at: 423)
--------------+---------+-------+---------+
Complexity:   |      33 |    ** | Warning |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |     112 |   *** | MONSTER |
LOC:          |     284 |   *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-08-19 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      80 |
LOC:                    39 |       179 |     251 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html