[GRASS-QA] GRASS QA: markus |
./grass6/vector/lidar/v.lidar.growing/ConvexHull.c |1 clones
( ConvexHull.c )| 1 monsters | 1 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Sat Aug 19 11:38:16 EDT 2006
Hello markus,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
vector/lidar/v.lidar.growing/ConvexHull.c functions
regGrow8 (Begins at: 11 Ends at: 64)
--------------+---------+-------+---------+
Complexity: | 17 | * | |
ParamNBR: | 9 | *** | MONSTER |
CalledNBR: | 9 | | OK |
LOC: | 54 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
ccw (Begins at: 67 Ends at: 76)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
cmpl (Begins at: 79 Ends at: 85)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
cmph (Begins at: 87 Ends at: 90)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
make_chain (Begins at: 92 Ends at: 107)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 2 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
ch2d (Begins at: 109 Ends at: 117)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
print_hull (Begins at: 119 Ends at: 128)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
checkHull (Begins at: 130 Ends at: 169)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 40 | | OK |
--------------+---------+-------+---------+
metrics are OK
pianOriz (Begins at: 172 Ends at: 214)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 8 | ** | Warning |
CalledNBR: | 0 | | OK |
LOC: | 43 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
Pvector (Begins at: 217 Ends at: 224)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
P_alloc_element (Begins at: 226 Ends at: 238)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
nrerror (Begins at: 240 Ends at: 247)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
structMatrix (Begins at: 249 Ends at: 272)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
free_Pvector (Begins at: 274 Ends at: 278)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
free_structmatrix (Begins at: 280 Ends at: 284)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 2 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
nrerror
In vector/lidar/v.lidar.growing/ConvexHull.c clones of nrerror are:
display/d.rast.edit/main.c ext
__________________________________________
Threshold GRASS6 key metrics values at 2006-08-19 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 36 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 9 | 55 | 80 |
LOC: 39 | 179 | 251 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list