[GRASS-QA] GRASS QA: markus | ./grass6/raster3d/r3.out.vtk/main.c |3 clones ( color_get.c dalloc.c dalloc.c main.c main.c main.c parser.c main.c main.c main.c count.c main.c main.c o_kurt.c o_skew.c topmodel.c areas.c parser.c dalloc.c mask_functions.c main.c main.c main.c )| 0 monsters | 2 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster3d/r3.out.vtk/main.c functions


create_input_maps_struct (Begins at: 56 Ends at: 81)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      26 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

open_input_map (Begins at: 86 Ends at: 101)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

check_input_maps (Begins at: 107 Ends at: 182)
--------------+---------+-------+---------+
Complexity:   |      14 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |      23 |       |      OK |
LOC:          |      76 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

open_write_rgb_maps (Begins at: 188 Ends at: 266)
--------------+---------+-------+---------+
Complexity:   |      19 |     * |         |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      20 |       |      OK |
LOC:          |      79 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

open_write_vector_maps (Begins at: 271 Ends at: 349)
--------------+---------+-------+---------+
Complexity:   |      19 |     * |         |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      20 |       |      OK |
LOC:          |      79 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

main (Begins at: 355 Ends at: 557)
--------------+---------+-------+---------+
Complexity:   |      24 |     * |         |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      67 |    ** | Warning |
LOC:          |     203 |    ** | Warning |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code

Clone analysis:

This file has 3 potentially cloned functions:
  open_input_map  open_write_vector_maps  open_write_rgb_maps

In raster3d/r3.out.vtk/main.c clones of  open_write_vector_maps are:
	raster3d/r3.out.vtk/main.c  open_write_rgb_maps

In raster3d/r3.out.vtk/main.c clones of  open_write_rgb_maps are:
	raster3d/r3.out.vtk/main.c  open_write_vector_maps

In raster3d/r3.out.vtk/main.c clones of  open_input_map are:
	raster/r.to.rast3/main.c  open_input_raster_map


__________________________________________

Threshold GRASS6 key metrics values at 2006-12-09 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html