[GRASS-QA] GRASS QA: hamish | ./grass6/vector/v.surf.rst/main.c |1 clones ( color_get.c dalloc.c dalloc.c main.c main.c main.c parser.c main.c main.c )| 3 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello hamish,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


vector/v.surf.rst/main.c functions


main (Begins at: 127 Ends at: 815)
--------------+---------+-------+---------+
Complexity:   |      90 |   *** | MONSTER |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |     283 |   *** | MONSTER |
LOC:          |     689 |   *** | MONSTER |
--------------+---------+-------+---------+
3 metric are OUT OF RANGE!

print_tree (Begins at: 819 Ends at: 857)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |      39 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

clean_fatal_error (Begins at: 861 Ends at: 888)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      13 |       |      OK |
LOC:          |      28 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 1 potentially cloned functions:
  clean_fatal_error

In vector/v.surf.rst/main.c clones of  clean_fatal_error are:
	raster/r.resamp.rst/main.c  clean_fatal_error


__________________________________________

Threshold GRASS6 key metrics values at 2006-12-09 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html