[GRASS-QA] GRASS QA: markus | ./grass6/raster/r.carve/enforce_ds.c |no clones | 0 monsters | 1 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.carve/enforce_ds.c functions


enforce_downstream (Begins at: 53 Ends at: 88)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      13 |       |      OK |
LOC:          |      36 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

process_line (Begins at: 91 Ends at: 202)
--------------+---------+-------+---------+
Complexity:   |      13 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      32 |       |      OK |
LOC:          |     112 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

clear_bitmap (Begins at: 205 Ends at: 212)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

traverse_line_flat (Begins at: 215 Ends at: 238)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

traverse_line_noflat (Begins at: 241 Ends at: 265)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      25 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

set_min_point (Begins at: 269 Ends at: 295)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       9 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

lowest_cell_near_point (Begins at: 299 Ends at: 416)
--------------+---------+-------+---------+
Complexity:   |      25 |     * |         |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      22 |       |      OK |
LOC:          |     118 |     * |         |
--------------+---------+-------+---------+
metrics are OK

process_line_segment (Begins at: 424 Ends at: 514)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      22 |       |      OK |
LOC:          |      91 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-12-13 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html