[GRASS-QA] GRASS QA: markus | ./grass6/raster/r.fill.dir/tinf.c |1
clones ( write.c write.c g3dclose.c main.c raster.c tinf.c )|
0 monsters | 0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Wed Dec 13 10:02:43 EST 2006
Hello markus,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
raster/r.fill.dir/tinf.c functions
set_func_pointers (Begins at: 13 Ends at: 72)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 60 | | OK |
--------------+---------+-------+---------+
metrics are OK
is_null_c (Begins at: 75 Ends at: 75)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
is_null_f (Begins at: 76 Ends at: 76)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
is_null_d (Begins at: 77 Ends at: 77)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
bpe_c (Begins at: 80 Ends at: 80)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
bpe_f (Begins at: 81 Ends at: 81)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
bpe_d (Begins at: 82 Ends at: 82)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_min_c (Begins at: 85 Ends at: 92)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_min_f (Begins at: 94 Ends at: 101)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_min_d (Begins at: 103 Ends at: 110)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_max_c (Begins at: 113 Ends at: 120)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_max_f (Begins at: 122 Ends at: 129)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_max_d (Begins at: 131 Ends at: 138)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_row_c (Begins at: 141 Ends at: 144)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_row_f (Begins at: 146 Ends at: 149)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_row_d (Begins at: 151 Ends at: 154)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
put_row_c (Begins at: 157 Ends at: 160)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
put_row_f (Begins at: 162 Ends at: 165)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
put_row_d (Begins at: 167 Ends at: 170)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_buf_c (Begins at: 173 Ends at: 176)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_buf_f (Begins at: 178 Ends at: 181)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_buf_d (Begins at: 183 Ends at: 186)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_min_c (Begins at: 189 Ends at: 189)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_min_f (Begins at: 190 Ends at: 190)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_min_d (Begins at: 191 Ends at: 191)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_max_c (Begins at: 194 Ends at: 194)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_max_f (Begins at: 195 Ends at: 195)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_max_d (Begins at: 196 Ends at: 196)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
diff_c (Begins at: 199 Ends at: 199)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
diff_f (Begins at: 200 Ends at: 200)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
diff_d (Begins at: 201 Ends at: 201)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
sum_c (Begins at: 204 Ends at: 204)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
sum_f (Begins at: 205 Ends at: 205)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
sum_d (Begins at: 206 Ends at: 206)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
quot_c (Begins at: 209 Ends at: 209)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
quot_f (Begins at: 210 Ends at: 210)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
quot_d (Begins at: 211 Ends at: 211)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
prod_c (Begins at: 214 Ends at: 214)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
prod_f (Begins at: 215 Ends at: 215)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
prod_d (Begins at: 216 Ends at: 216)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
slope_c (Begins at: 220 Ends at: 232)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
slope_f (Begins at: 234 Ends at: 246)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
slope_d (Begins at: 248 Ends at: 260)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
advance_band3 (Begins at: 264 Ends at: 276)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
retreat_band3 (Begins at: 280 Ends at: 296)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
retreat_band3
In raster/r.fill.dir/tinf.c clones of retreat_band3 are:
raster/r.drain/tinf.c retreat_band3
__________________________________________
Threshold GRASS6 key metrics values at 2006-12-13 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 10 | 60 | 86 |
LOC: 42 | 190 | 265 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list