[GRASS-QA] GRASS QA: markus | ./grass6/raster/r.to.rast3elev/main.c |1 clones ( write.c write.c g3dclose.c main.c raster.c tinf.c count.c main.c main.c main.c )| 0 monsters | 1 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.to.rast3elev/main.c functions


get_raster_value_as_double (Begins at: 64 Ends at: 94)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      31 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

check_input_maps (Begins at: 99 Ends at: 146)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      13 |       |      OK |
LOC:          |      48 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

open_input_raster_map (Begins at: 151 Ends at: 164)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

close_input_raster_map (Begins at: 169 Ends at: 173)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

fatal_error (Begins at: 178 Ends at: 195)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

set_params (Begins at: 200 Ends at: 236)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |      13 |       |      OK |
LOC:          |      37 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

elev_raster_to_g3d (Begins at: 241 Ends at: 375)
--------------+---------+-------+---------+
Complexity:   |      22 |     * |         |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      33 |       |      OK |
LOC:          |     135 |     * |         |
--------------+---------+-------+---------+
metrics are OK

main (Begins at: 380 Ends at: 555)
--------------+---------+-------+---------+
Complexity:   |      18 |     * |         |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      62 |    ** | Warning |
LOC:          |     176 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file has 1 potentially cloned functions:
  get_raster_value_as_double

In raster/r.to.rast3elev/main.c clones of  get_raster_value_as_double are:
	raster3d/r3.out.vtk/writeVTKData.c  get_raster_value_as_double
	raster/r.out.vtk/writeascii.c  get_raster_value_as_double


__________________________________________

Threshold GRASS6 key metrics values at 2006-12-13 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html