[GRASS-QA] GRASS QA: markus | ./grass6/lib/gis/color_look.c |no clones | 1 monsters | 5 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/gis/color_look.c functions


G_lookup_colors (Begins at: 38 Ends at: 76)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       1 |       |      OK |
LOC:          |      39 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G_lookup_c_raster_colors (Begins at: 78 Ends at: 118)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       4 |       |      OK |
LOC:          |      41 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G_lookup_raster_colors (Begins at: 120 Ends at: 158)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |       4 |       |      OK |
LOC:          |      39 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G_lookup_f_raster_colors (Begins at: 160 Ends at: 193)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       4 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G_lookup_d_raster_colors (Begins at: 195 Ends at: 210)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       4 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

less_or_equal (Begins at: 213 Ends at: 218)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

less (Begins at: 220 Ends at: 225)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G__lookup_colors (Begins at: 228 Ends at: 455)
--------------+---------+-------+---------+
Complexity:   |      29 |    ** | Warning |
ParamNBR:     |      10 |   *** | MONSTER |
CalledNBR:    |      11 |       |      OK |
LOC:          |     228 |    ** | Warning |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

G__interpolate_color_rule (Begins at: 457 Ends at: 481)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       0 |       |      OK |
LOC:          |      25 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-12-13 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html