[GRASS-QA] GRASS QA: markus | ./grass6/lib/gis/get_row.c |3 clones
( alloc.c cats.c color_read.c find_cell.c get_row.c )| 0
monsters | 0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Wed Dec 13 10:37:30 EST 2006
Hello markus,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/gis/get_row.c functions
compute_window_row (Begins at: 101 Ends at: 128)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
do_reclass_int (Begins at: 132 Ends at: 164)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
read_data_fp_compressed (Begins at: 168 Ends at: 185)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
rle_decompress (Begins at: 189 Ends at: 208)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
read_data_compressed (Begins at: 210 Ends at: 247)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 38 | | OK |
--------------+---------+-------+---------+
metrics are OK
read_data_uncompressed (Begins at: 251 Ends at: 265)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
read_data (Begins at: 271 Ends at: 284)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
cell_values_int (Begins at: 290 Ends at: 338)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 0 | | OK |
LOC: | 49 | | OK |
--------------+---------+-------+---------+
metrics are OK
cell_values_float (Begins at: 342 Ends at: 382)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 5 | | OK |
LOC: | 41 | | OK |
--------------+---------+-------+---------+
metrics are OK
cell_values_double (Begins at: 386 Ends at: 442)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 5 | | OK |
LOC: | 57 | | OK |
--------------+---------+-------+---------+
metrics are OK
transfer_to_cell_XX (Begins at: 444 Ends at: 455)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
transfer_to_cell_fi (Begins at: 459 Ends at: 470)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
transfer_to_cell_di (Begins at: 472 Ends at: 483)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
transfer_to_cell_if (Begins at: 487 Ends at: 495)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
transfer_to_cell_df (Begins at: 497 Ends at: 505)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
transfer_to_cell_id (Begins at: 509 Ends at: 517)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
transfer_to_cell_fd (Begins at: 519 Ends at: 527)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_map_row_nomask (Begins at: 533 Ends at: 580)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 48 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_map_row_no_reclass (Begins at: 584 Ends at: 599)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 2 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_map_row (Begins at: 603 Ends at: 676)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 5 | | OK |
LOC: | 74 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_map_row_nomask (Begins at: 678 Ends at: 694)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_raster_row_nomask (Begins at: 696 Ends at: 710)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_c_raster_row_nomask (Begins at: 712 Ends at: 726)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_f_raster_row_nomask (Begins at: 728 Ends at: 742)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_d_raster_row_nomask (Begins at: 744 Ends at: 763)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_map_row (Begins at: 765 Ends at: 783)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_raster_row (Begins at: 785 Ends at: 806)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_c_raster_row (Begins at: 808 Ends at: 826)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_f_raster_row (Begins at: 828 Ends at: 843)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_d_raster_row (Begins at: 845 Ends at: 848)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
open_null_read (Begins at: 854 Ends at: 894)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 41 | | OK |
--------------+---------+-------+---------+
metrics are OK
read_null_bits (Begins at: 896 Ends at: 928)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 9 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_null_value_row_nomask (Begins at: 930 Ends at: 1017)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 13 | | OK |
LOC: | 88 | | OK |
--------------+---------+-------+---------+
metrics are OK
embed_mask (Begins at: 1023 Ends at: 1039)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_null_value_row (Begins at: 1041 Ends at: 1047)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
embed_nulls (Begins at: 1049 Ends at: 1078)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 5 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_null_value_row (Begins at: 1084 Ends at: 1089)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 3 potentially cloned functions:
G_get_raster_row_nomask G_get_f_raster_row_nomask G_get_c_raster_row_nomask
In lib/gis/get_row.c clones of G_get_f_raster_row_nomask are:
lib/gis/get_row.c G_get_c_raster_row_nomask
In lib/gis/get_row.c clones of G_get_raster_row_nomask are:
lib/vector/Vlib/read_nat.c V1_read_line_nat
In lib/gis/get_row.c clones of G_get_c_raster_row_nomask are:
lib/gis/get_row.c G_get_f_raster_row_nomask
__________________________________________
Threshold GRASS6 key metrics values at 2006-12-13 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 10 | 60 | 86 |
LOC: 42 | 190 | 265 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list