[GRASS-QA] GRASS QA: markus | ./grass6/raster/r.walk/main.c |1 clones ( alloc.c cats.c color_read.c find_cell.c get_row.c opencell.c range.c ps_outline.c main.c main.c tinf.c main.c main.c main.c )| 3 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.walk/main.c functions


main (Begins at: 81 Ends at: 1511)
--------------+---------+-------+---------+
Complexity:   |     196 |   *** | MONSTER |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |     410 |   *** | MONSTER |
LOC:          |    1431 |   *** | MONSTER |
--------------+---------+-------+---------+
3 metric are OUT OF RANGE!

process_answers (Begins at: 1517 Ends at: 1566)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      11 |       |      OK |
LOC:          |      50 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

time_to_stop (Begins at: 1571 Ends at: 1591)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      21 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 1 potentially cloned functions:
  time_to_stop

In raster/r.walk/main.c clones of  time_to_stop are:
	raster/r.cost/main.c  time_to_stop


__________________________________________

Threshold GRASS6 key metrics values at 2006-12-13 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html