[GRASS-QA] GRASS QA: brad | ./grass6/raster/r.surf.idw/main.c |no clones | 0 monsters | 3 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Fri Dec 15 03:56:43 EST 2006



Hello brad,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.surf.idw/main.c functions


main (Begins at: 28 Ends at: 153)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      50 |     * |         |
LOC:          |     126 |     * |         |
--------------+---------+-------+---------+
metrics are OK

lookup_and_function_ptrs (Begins at: 155 Ends at: 188)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

interpolate (Begins at: 191 Ends at: 279)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      10 |       |      OK |
LOC:          |      89 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

make_neighbors_list (Begins at: 281 Ends at: 344)
--------------+---------+-------+---------+
Complexity:   |      11 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      10 |       |      OK |
LOC:          |      64 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

search (Begins at: 349 Ends at: 395)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |       8 |       |      OK |
LOC:          |      47 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

exhaust (Begins at: 398 Ends at: 424)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

offset_distance (Begins at: 426 Ends at: 429)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

completed_row (Begins at: 435 Ends at: 438)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

next_row (Begins at: 441 Ends at: 456)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

first_west (Begins at: 464 Ends at: 478)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

find_neighbors (Begins at: 486 Ends at: 514)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       3 |       |      OK |
LOC:          |      29 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

exhaust_search (Begins at: 521 Ends at: 543)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      23 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

triangulate (Begins at: 550 Ends at: 558)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

add_neighbor (Begins at: 561 Ends at: 576)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

replace_neighbor (Begins at: 579 Ends at: 601)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      23 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

sort_neighbors (Begins at: 604 Ends at: 617)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

free_row_lists (Begins at: 621 Ends at: 638)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

row_lists (Begins at: 641 Ends at: 701)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       8 |       |      OK |
LOC:          |      61 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

lookup_tables (Begins at: 708 Ends at: 726)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-12-15 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list