[GRASS-QA] GRASS QA: markus | ./grass6/display/d.rast.edit/edit.c |1 clones ( edit.c )| 1 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


display/d.rast.edit/edit.c functions


edit (Begins at: 22 Ends at: 315)
--------------+---------+-------+---------+
Complexity:   |      24 |     * |         |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      82 |    ** | Warning |
LOC:          |     294 |   *** | MONSTER |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

edit_mouse_info (Begins at: 317 Ends at: 329)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

edit_mouse_info2 (Begins at: 331 Ends at: 364)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      18 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

use_mouse (Begins at: 367 Ends at: 376)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 1 potentially cloned functions:
  use_mouse

In display/d.rast.edit/edit.c clones of  use_mouse are:
	imagery/i.class/signature.c  write_signatures


__________________________________________

Threshold GRASS6 key metrics values at 2006-12-15 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html