[GRASS-QA] GRASS QA: glynn | ./grass6/lib/gis/sample.c |no clones | 0 monsters | 4 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/gis/sample.c functions


G_get_raster_sample (Begins at: 54 Ends at: 78)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       5 |       |      OK |
LOC:          |      25 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

raster_sample_nearest (Begins at: 81 Ends at: 116)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |      10 |       |      OK |
LOC:          |      36 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

raster_sample_bilinear (Begins at: 119 Ends at: 249)
--------------+---------+-------+---------+
Complexity:   |      18 |     * |         |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |      44 |     * |         |
LOC:          |     131 |     * |         |
--------------+---------+-------+---------+
metrics are OK

raster_sample_cubic (Begins at: 252 Ends at: 462)
--------------+---------+-------+---------+
Complexity:   |      36 |   *** | MONSTER |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |      79 |    ** | Warning |
LOC:          |     211 |    ** | Warning |
--------------+---------+-------+---------+
at least 3 values are close to an outlier please consider revising code

scancatlabel (Begins at: 465 Ends at: 478)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

raster_row_error (Begins at: 481 Ends at: 488)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-12-21 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html