[GRASS-QA] GRASS QA: hamish | ./grass6/imagery/i.vpoints/points.c |2 clones ( analyze.c ask.c input.c analyze.c analyze.c ask.c input.c input.c mark.c points.c )| 0 monsters | 0 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello hamish,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


imagery/i.vpoints/points.c functions


display_points (Begins at: 6 Ends at: 26)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      21 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

display_points_in_view (Begins at: 28 Ends at: 45)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       4 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

display_one_point (Begins at: 47 Ends at: 59)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 2 potentially cloned functions:
  display_points_in_view  display_one_point

In imagery/i.vpoints/points.c clones of  display_one_point are:
	imagery/i.points/points.c  display_one_point
	imagery/i.ortho.photo/photo.2image/points.c  display_one_point

In imagery/i.vpoints/points.c clones of  display_points_in_view are:
	imagery/i.points/points.c  display_points_in_view
	imagery/i.ortho.photo/photo.2image/points.c  display_ref_points_in_view


__________________________________________

Threshold GRASS6 key metrics values at 2006-07-05 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    40 |       180 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html