[GRASS-QA] GRASS QA: brad | ./grass6/raster/r.param.scale/nrutil.c |7 clones ( nrutil.c )| 0 monsters | 2 warnings

cvs at proxy.soccerlab.polymtl.ca cvs at proxy.soccerlab.polymtl.ca
Sat Jul 8 05:20:51 EDT 2006


Hello brad,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.param.scale/nrutil.c functions


vector (Begins at: 25 Ends at: 32)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

ivector (Begins at: 36 Ends at: 43)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

cvector (Begins at: 47 Ends at: 54)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

lvector (Begins at: 58 Ends at: 65)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dvector (Begins at: 69 Ends at: 76)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

matrix (Begins at: 80 Ends at: 99)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      20 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dmatrix (Begins at: 103 Ends at: 122)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      20 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

imatrix (Begins at: 126 Ends at: 146)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      21 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

submatrix (Begins at: 150 Ends at: 166)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       1 |       |      OK |
LOC:          |      17 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

convert_matrix (Begins at: 173 Ends at: 189)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |      17 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

f3tensor (Begins at: 193 Ends at: 223)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       3 |       |      OK |
LOC:          |      31 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

free_vector (Begins at: 227 Ends at: 230)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

free_ivector (Begins at: 234 Ends at: 237)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

free_cvector (Begins at: 241 Ends at: 244)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

free_lvector (Begins at: 248 Ends at: 251)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

free_dvector (Begins at: 255 Ends at: 258)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

free_matrix (Begins at: 262 Ends at: 266)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       2 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

free_dmatrix (Begins at: 270 Ends at: 274)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       2 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

free_imatrix (Begins at: 278 Ends at: 282)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       2 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

free_submatrix (Begins at: 286 Ends at: 289)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

free_convert_matrix (Begins at: 293 Ends at: 296)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

free_f3tensor (Begins at: 300 Ends at: 306)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       3 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file has 7 potentially cloned functions:
  dmatrix  matrix  dvector  lvector  cvector  ivector  vector

In raster/r.param.scale/nrutil.c clones of  dvector are:
	raster/r.param.scale/nrutil.c  lvector
	raster/r.param.scale/nrutil.c  cvector
	raster/r.param.scale/nrutil.c  ivector
	raster/r.param.scale/nrutil.c  vector

In raster/r.param.scale/nrutil.c clones of  cvector are:
	raster/r.param.scale/nrutil.c  dvector
	raster/r.param.scale/nrutil.c  lvector
	raster/r.param.scale/nrutil.c  ivector
	raster/r.param.scale/nrutil.c  vector

In raster/r.param.scale/nrutil.c clones of  dmatrix are:
	raster/r.param.scale/nrutil.c  matrix

In raster/r.param.scale/nrutil.c clones of  lvector are:
	raster/r.param.scale/nrutil.c  dvector
	raster/r.param.scale/nrutil.c  cvector
	raster/r.param.scale/nrutil.c  ivector
	raster/r.param.scale/nrutil.c  vector

In raster/r.param.scale/nrutil.c clones of  matrix are:
	raster/r.param.scale/nrutil.c  dmatrix

In raster/r.param.scale/nrutil.c clones of  vector are:
	raster/r.param.scale/nrutil.c  dvector
	raster/r.param.scale/nrutil.c  lvector
	raster/r.param.scale/nrutil.c  cvector
	raster/r.param.scale/nrutil.c  ivector

In raster/r.param.scale/nrutil.c clones of  ivector are:
	raster/r.param.scale/nrutil.c  dvector
	raster/r.param.scale/nrutil.c  lvector
	raster/r.param.scale/nrutil.c  cvector
	raster/r.param.scale/nrutil.c  vector


__________________________________________

Threshold GRASS6 key metrics values at 2006-07-08 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    40 |       180 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list