[GRASS-QA] GRASS QA: glynn | ./grass6/lib/ogsf/gsd_views.c |2 clones ( GS2.c gsd_views.c )| 0 monsters | 0 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/ogsf/gsd_views.c functions


gsd_get_los (Begins at: 32 Ends at: 81)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      21 |       |      OK |
LOC:          |      50 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_set_view (Begins at: 86 Ends at: 122)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      12 |       |      OK |
LOC:          |      37 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_check_focus (Begins at: 125 Ends at: 141)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      17 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_get_zup (Begins at: 144 Ends at: 170)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_zup_twist (Begins at: 173 Ends at: 248)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      12 |       |      OK |
LOC:          |      76 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_do_scale (Begins at: 251 Ends at: 262)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_real2model (Begins at: 265 Ends at: 278)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_model2real (Begins at: 281 Ends at: 294)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_model2surf (Begins at: 297 Ends at: 318)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_surf2real (Begins at: 321 Ends at: 329)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_real2surf (Begins at: 332 Ends at: 340)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 2 potentially cloned functions:
  gsd_model2real  gsd_real2model

In lib/ogsf/gsd_views.c clones of  gsd_model2real are:
	lib/ogsf/gsd_views.c  gsd_real2model

In lib/ogsf/gsd_views.c clones of  gsd_real2model are:
	lib/ogsf/gsd_views.c  gsd_model2real


__________________________________________

Threshold GRASS6 key metrics values at 2006-07-09 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    40 |       180 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html