[GRASS-QA] GRASS QA: markus | ./grass6/raster/r.mapcalc/xif.c |2 clones ( xif.c )| 0 monsters | 0 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.mapcalc/xif.c functions


f_if_i (Begins at: 15 Ends at: 99)
--------------+---------+-------+---------+
Complexity:   |      22 |     * |         |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      20 |       |      OK |
LOC:          |      85 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

f_if_f (Begins at: 102 Ends at: 181)
--------------+---------+-------+---------+
Complexity:   |      21 |     * |         |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      18 |       |      OK |
LOC:          |      80 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

f_if_d (Begins at: 184 Ends at: 263)
--------------+---------+-------+---------+
Complexity:   |      21 |     * |         |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      18 |       |      OK |
LOC:          |      80 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

f_if (Begins at: 266 Ends at: 289)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

c_if (Begins at: 292 Ends at: 315)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 2 potentially cloned functions:
  f_if_d  f_if_f

In raster/r.mapcalc/xif.c clones of  f_if_f are:
	raster/r.mapcalc/xif.c  f_if_d

In raster/r.mapcalc/xif.c clones of  f_if_d are:
	raster/r.mapcalc/xif.c  f_if_f


__________________________________________

Threshold GRASS6 key metrics values at 2006-07-20 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      80 |
LOC:                    40 |       180 |     253 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html