[GRASS-QA] GRASS QA: markus | ./grass6/vector/v.out.dxf/write_dxf.c
|3 clones ( write_dxf.c )| 0 monsters | 1 warnings
cvs at proxy.soccerlab.polymtl.ca
cvs at proxy.soccerlab.polymtl.ca
Sat Jul 22 05:54:15 EDT 2006
Hello markus,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
vector/v.out.dxf/write_dxf.c functions
dxf_open (Begins at: 15 Ends at: 30)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
dxf_header (Begins at: 32 Ends at: 37)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
dxf_tables (Begins at: 39 Ends at: 44)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
dxf_blocks (Begins at: 46 Ends at: 51)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
dxf_entities (Begins at: 53 Ends at: 58)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
dxf_endsec (Begins at: 60 Ends at: 65)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
dxf_eof (Begins at: 67 Ends at: 73)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
dxf_limits (Begins at: 77 Ends at: 83)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
dxf_linetype_table (Begins at: 87 Ends at: 92)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
dxf_layer_table (Begins at: 94 Ends at: 99)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
dxf_endtable (Begins at: 101 Ends at: 106)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
dxf_solidline (Begins at: 108 Ends at: 115)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
dxf_layer0 (Begins at: 117 Ends at: 123)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
dxf_layer (Begins at: 125 Ends at: 137)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
dxf_point (Begins at: 141 Ends at: 148)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
dxf_polyline (Begins at: 150 Ends at: 158)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
dxf_vertex (Begins at: 160 Ends at: 167)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
dxf_text (Begins at: 169 Ends at: 178)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 3 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
dxf_poly_end (Begins at: 180 Ends at: 185)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 3 potentially cloned functions:
dxf_layer dxf_vertex dxf_point
In vector/v.out.dxf/write_dxf.c clones of dxf_layer are:
visualization/nviz/src/position.c Nget_xyrange_cmd
In vector/v.out.dxf/write_dxf.c clones of dxf_vertex are:
vector/v.out.dxf/write_dxf.c dxf_point
In vector/v.out.dxf/write_dxf.c clones of dxf_point are:
vector/v.out.dxf/write_dxf.c dxf_vertex
__________________________________________
Threshold GRASS6 key metrics values at 2006-07-22 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 9 | 55 | 80 |
LOC: 40 | 180 | 253 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list