[GRASS-QA] GRASS QA: markus | ./grass6/lib/ogsf/GS2.c |6 clones (
GS2.c )| 2 monsters | 2 warnings
cvs at proxy.soccerlab.polymtl.ca
cvs at proxy.soccerlab.polymtl.ca
Tue Jul 25 15:19:39 EDT 2006
Hello markus,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/ogsf/GS2.c functions
void_func (Begins at: 64 Ends at: 67)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_libinit (Begins at: 70 Ends at: 101)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 32 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_longdim (Begins at: 104 Ends at: 108)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_region (Begins at: 111 Ends at: 119)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_att_defaults (Begins at: 122 Ends at: 138)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_surf_exists (Begins at: 141 Ends at: 162)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_new_surface (Begins at: 169 Ends at: 196)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_new_light (Begins at: 199 Ends at: 229)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_setlight_position (Begins at: 233 Ends at: 249)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_getlight_position (Begins at: 253 Ends at: 268)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 0 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_setlight_color (Begins at: 271 Ends at: 285)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_getlight_color (Begins at: 288 Ends at: 300)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_setlight_ambient (Begins at: 303 Ends at: 317)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_getlight_ambient (Begins at: 320 Ends at: 332)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_lights_off (Begins at: 336 Ends at: 345)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_lights_on (Begins at: 348 Ends at: 357)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_switchlight (Begins at: 360 Ends at: 371)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_transp_is_set (Begins at: 374 Ends at: 377)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_modelposition1 (Begins at: 380 Ends at: 396)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_modelposition (Begins at: 401 Ends at: 424)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_Narrow (Begins at: 432 Ends at: 493)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 62 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_X (Begins at: 497 Ends at: 528)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 32 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_line_onsurf (Begins at: 531 Ends at: 556)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 10 | | OK |
LOC: | 26 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_nline_onsurf (Begins at: 562 Ends at: 589)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 11 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
GS_draw_flowline_at_xy (Begins at: 595 Ends at: 656)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 62 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_fringe (Begins at: 661 Ends at: 668)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_legend (Begins at: 673 Ends at: 683)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 1 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_list (Begins at: 686 Ends at: 695)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_all_list (Begins at: 698 Ends at: 707)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_delete_list (Begins at: 710 Ends at: 716)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_lighting_model1 (Begins at: 719 Ends at: 751)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 13 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_lighting_model (Begins at: 756 Ends at: 800)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 15 | | OK |
LOC: | 45 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_update_curmask (Begins at: 806 Ends at: 812)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_is_masked (Begins at: 815 Ends at: 828)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_unset_SDsurf (Begins at: 831 Ends at: 837)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_SDsurf (Begins at: 840 Ends at: 852)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_SDscale (Begins at: 855 Ends at: 860)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_SDsurf (Begins at: 863 Ends at: 874)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_SDscale (Begins at: 877 Ends at: 882)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_update_normals (Begins at: 885 Ends at: 892)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_att (Begins at: 895 Ends at: 927)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 4 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_cat_at_xy (Begins at: 929 Ends at: 979)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 12 | | OK |
LOC: | 51 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_norm_at_xy (Begins at: 986 Ends at: 1032)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 47 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_val_at_xy (Begins at: 1040 Ends at: 1111)
--------------+---------+-------+---------+
Complexity: | 9 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 16 | | OK |
LOC: | 72 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_unset_att (Begins at: 1116 Ends at: 1124)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_att_const (Begins at: 1127 Ends at: 1138)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_maskmode (Begins at: 1142 Ends at: 1156)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_maskmode (Begins at: 1159 Ends at: 1172)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_Set_ClientData (Begins at: 1175 Ends at: 1187)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_Get_ClientData (Begins at: 1190 Ends at: 1200)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_num_surfs (Begins at: 1203 Ends at: 1206)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_surf_list (Begins at: 1210 Ends at: 1230)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_delete_surface (Begins at: 1233 Ends at: 1279)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 47 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_load_att_map (Begins at: 1281 Ends at: 1589)
--------------+---------+-------+---------+
Complexity: | 40 | *** | MONSTER |
ParamNBR: | 3 | | OK |
CalledNBR: | 66 | ** | Warning |
LOC: | 309 | *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!
GS_draw_surf (Begins at: 1592 Ends at: 1622)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_wire (Begins at: 1626 Ends at: 1643)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_alldraw_wire (Begins at: 1647 Ends at: 1659)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_alldraw_surf (Begins at: 1662 Ends at: 1671)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_exag (Begins at: 1674 Ends at: 1695)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_global_exag (Begins at: 1698 Ends at: 1717)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_global_exag (Begins at: 1720 Ends at: 1729)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_wire_color (Begins at: 1732 Ends at: 1749)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_wire_color (Begins at: 1752 Ends at: 1765)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_setall_drawmode (Begins at: 1768 Ends at: 1779)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_drawmode (Begins at: 1782 Ends at: 1801)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_drawmode (Begins at: 1804 Ends at: 1817)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_nozero (Begins at: 1820 Ends at: 1845)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 26 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_nozero (Begins at: 1848 Ends at: 1875)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_setall_drawres (Begins at: 1878 Ends at: 1889)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_drawres (Begins at: 1892 Ends at: 1920)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 1 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_drawres (Begins at: 1923 Ends at: 1943)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 1 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_dims (Begins at: 1946 Ends at: 1964)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_exag_guess (Begins at: 1970 Ends at: 2019)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 50 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_zrange_nz (Begins at: 2022 Ends at: 2046)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_trans (Begins at: 2049 Ends at: 2068)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_trans (Begins at: 2071 Ends at: 2090)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_default_draw_color (Begins at: 2094 Ends at: 2104)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_background_color (Begins at: 2107 Ends at: 2110)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_draw (Begins at: 2113 Ends at: 2137)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_ready_draw (Begins at: 2140 Ends at: 2152)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_done_draw (Begins at: 2155 Ends at: 2171)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_focus (Begins at: 2174 Ends at: 2188)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_focus_real (Begins at: 2190 Ends at: 2203)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_focus (Begins at: 2208 Ends at: 2224)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_focus_center_map (Begins at: 2227 Ends at: 2259)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_moveto (Begins at: 2262 Ends at: 2290)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_moveto_real (Begins at: 2293 Ends at: 2299)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_zextents (Begins at: 2303 Ends at: 2318)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_zrange (Begins at: 2322 Ends at: 2354)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_from (Begins at: 2357 Ends at: 2369)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_from_real (Begins at: 2372 Ends at: 2378)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_to_real (Begins at: 2381 Ends at: 2392)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_zoom_setup (Begins at: 2398 Ends at: 2411)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_to (Begins at: 2415 Ends at: 2427)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_viewdir (Begins at: 2430 Ends at: 2435)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_viewdir (Begins at: 2439 Ends at: 2452)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_fov (Begins at: 2455 Ends at: 2460)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_fov (Begins at: 2463 Ends at: 2466)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_twist (Begins at: 2469 Ends at: 2472)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_twist (Begins at: 2476 Ends at: 2481)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_nofocus (Begins at: 2484 Ends at: 2496)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_infocus (Begins at: 2502 Ends at: 2514)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_viewport (Begins at: 2519 Ends at: 2531)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_look_here (Begins at: 2537 Ends at: 2570)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 34 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_selected_point_on_surface (Begins at: 2573 Ends at: 2634)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 12 | | OK |
LOC: | 62 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_cplane_rot (Begins at: 2637 Ends at: 2642)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_cplane_trans (Begins at: 2645 Ends at: 2650)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_cplane (Begins at: 2654 Ends at: 2670)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_cplane_fence (Begins at: 2673 Ends at: 2688)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_alldraw_cplane_fences (Begins at: 2691 Ends at: 2704)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_cplane (Begins at: 2707 Ends at: 2712)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_unset_cplane (Begins at: 2715 Ends at: 2720)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_scale (Begins at: 2723 Ends at: 2732)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_fencecolor (Begins at: 2735 Ends at: 2740)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_fencecolor (Begins at: 2743 Ends at: 2746)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_distance_alongsurf (Begins at: 2753 Ends at: 2771)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 4 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
GS_save_3dview (Begins at: 2774 Ends at: 2777)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_load_3dview (Begins at: 2780 Ends at: 2787)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_init_view (Begins at: 2794 Ends at: 2859)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 66 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_clear (Begins at: 2862 Ends at: 2894)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_aspect (Begins at: 2897 Ends at: 2919)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_has_transparency (Begins at: 2921 Ends at: 2935)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 6 potentially cloned functions:
GS_surf_exists GS_get_drawmode GS_get_wire_color GS_draw_wire GS_setlight_ambient GS_setlight_color
In lib/ogsf/GS2.c clones of GS_get_drawmode are:
lib/ogsf/GVL2.c GVL_slice_get_drawmode
lib/ogsf/GVL2.c GVL_isosurf_get_drawmode
lib/ogsf/GS2.c GS_get_wire_color
In lib/ogsf/GS2.c clones of GS_setlight_color are:
lib/ogsf/GS2.c GS_setlight_ambient
In lib/ogsf/GS2.c clones of GS_setlight_ambient are:
lib/ogsf/GS2.c GS_setlight_color
In lib/ogsf/GS2.c clones of GS_get_wire_color are:
lib/ogsf/GVL2.c GVL_slice_get_drawmode
lib/ogsf/GVL2.c GVL_isosurf_get_drawmode
lib/ogsf/GS2.c GS_get_drawmode
In lib/ogsf/GS2.c clones of GS_surf_exists are:
lib/ogsf/GVL2.c GVL_vol_exists
lib/ogsf/GV2.c GV_vect_exists
lib/ogsf/GP2.c GP_site_exists
In lib/ogsf/GS2.c clones of GS_draw_wire are:
lib/ogsf/gvl.c gvl_delete_vol
lib/ogsf/gv.c gv_delete_vect
lib/ogsf/gs.c gs_delete_surf
lib/ogsf/gp.c gp_delete_site
lib/ogsf/GVL2.c GVL_draw_wire
__________________________________________
Threshold GRASS6 key metrics values at 2006-07-25 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 36 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 9 | 55 | 79 |
LOC: 39 | 179 | 249 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list