[GRASS-QA] SOCCER LAB GRASS QA: 7 clones ( Dscreen.c list.c
get_row.c get_row.c put_row.c put_row.c vect.c areas.c draw.c
) 0 monsters and 0 warnings
cvs at proxy.soccerlab.polymtl.ca
cvs at proxy.soccerlab.polymtl.ca
Tue Jun 13 05:58:47 EDT 2006
Hello cedric,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
visualization/nviz/src/draw.c functions
CancelFunc_Hook (Begins at: 32 Ends at: 37)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nunset_cancel_func_cmd (Begins at: 42 Ends at: 53)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nset_cancel_func_cmd (Begins at: 58 Ends at: 78)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nset_draw_cmd (Begins at: 80 Ends at: 99)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
Ntransp_is_set_cmd (Begins at: 101 Ends at: 111)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nis_masked_cmd (Begins at: 113 Ends at: 132)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nhas_transparency_cmd (Begins at: 134 Ends at: 145)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_def_color_cmd (Begins at: 147 Ends at: 157)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nclear_cmd (Begins at: 159 Ends at: 170)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
Ndraw_wire_cmd (Begins at: 172 Ends at: 186)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
Ndraw_X_cmd (Begins at: 189 Ends at: 206)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nset_Narrow_cmd (Begins at: 213 Ends at: 247)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 35 | | OK |
--------------+---------+-------+---------+
metrics are OK
Ndraw_Narrow_cmd (Begins at: 254 Ends at: 276)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
Ndraw_line_on_surf_cmd (Begins at: 279 Ends at: 299)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
Ndraw_model_cmd (Begins at: 301 Ends at: 308)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsurf_draw_one_cmd (Begins at: 310 Ends at: 347)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 12 | | OK |
LOC: | 38 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nvect_draw_one_cmd (Begins at: 349 Ends at: 371)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 10 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsite_draw_one_cmd (Begins at: 373 Ends at: 394)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 10 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nvol_draw_one_cmd (Begins at: 396 Ends at: 418)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 10 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nauto_draw_cmd (Begins at: 424 Ends at: 433)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
auto_draw (Begins at: 440 Ends at: 454)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsurf_draw_all_cmd (Begins at: 457 Ends at: 466)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
sort_surfs_max (Begins at: 472 Ends at: 500)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
surf_draw_all (Begins at: 502 Ends at: 558)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 17 | | OK |
LOC: | 57 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nset_cancel_cmd (Begins at: 562 Ends at: 574)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nvect_draw_all_cmd (Begins at: 576 Ends at: 607)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 10 | | OK |
LOC: | 32 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsite_draw_all_cmd (Begins at: 609 Ends at: 640)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 13 | | OK |
LOC: | 32 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nvol_draw_all_cmd (Begins at: 642 Ends at: 671)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 10 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nready_draw_cmd (Begins at: 673 Ends at: 677)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
Ndone_draw_cmd (Begins at: 679 Ends at: 683)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_blank (Begins at: 691 Ends at: 721)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
Ndraw_legend_cmd (Begins at: 723 Ends at: 768)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 18 | | OK |
LOC: | 46 | | OK |
--------------+---------+-------+---------+
metrics are OK
Ndelete_list_cmd (Begins at: 770 Ends at: 800)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
Ndraw_fringe_cmd (Begins at: 804 Ends at: 821)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nset_viewport_cmd (Begins at: 828 Ends at: 849)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 7 potentially cloned functions:
Ntransp_is_set_cmd Nsurf_draw_all_cmd Nauto_draw_cmd Ndraw_wire_cmd Ndraw_line_on_surf_cmd Nvol_draw_one_cmd Nvect_draw_one_cmd
In visualization/nviz/src/draw.c clones of Nvol_draw_one_cmd are:
visualization/nviz/src/draw.c Nvect_draw_one_cmd
In visualization/nviz/src/draw.c clones of Ndraw_line_on_surf_cmd are:
visualization/nviz/src/lights.c setlgt_position
In visualization/nviz/src/draw.c clones of Ndraw_wire_cmd are:
visualization/nviz/src/position.c Nset_fov_cmd
In visualization/nviz/src/draw.c clones of Ntransp_is_set_cmd are:
lib/imagery/fopen.c error
In visualization/nviz/src/draw.c clones of Nsurf_draw_all_cmd are:
visualization/nviz/src/draw.c Nauto_draw_cmd
In visualization/nviz/src/draw.c clones of Nvect_draw_one_cmd are:
visualization/nviz/src/draw.c Nvol_draw_one_cmd
In visualization/nviz/src/draw.c clones of Nauto_draw_cmd are:
visualization/nviz/src/draw.c Nsurf_draw_all_cmd
__________________________________________
Threshold GRASS6 key metrics values at 2006-06-13 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 9 | 55 | 79 |
LOC: 40 | 180 | 252 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list