[GRASS-QA] SOCCER LAB GRASS QA: 8 clones ( Dscreen.c list.c
get_row.c get_row.c put_row.c put_row.c ) 0 monsters and 6 warnings
cvs at proxy.soccerlab.polymtl.ca
cvs at proxy.soccerlab.polymtl.ca
Tue Jun 13 05:58:45 EDT 2006
Hello brad,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/gis/put_row.c functions
G_zeros_r_nulls (Begins at: 160 Ends at: 166)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_put_map_row_random (Begins at: 168 Ends at: 189)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 5 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__put_null_value_row (Begins at: 191 Ends at: 204)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_put_map_row (Begins at: 206 Ends at: 218)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_put_raster_row (Begins at: 220 Ends at: 223)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_put_c_raster_row (Begins at: 225 Ends at: 228)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_put_f_raster_row (Begins at: 230 Ends at: 233)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_put_d_raster_row (Begins at: 235 Ends at: 238)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_open (Begins at: 242 Ends at: 279)
--------------+---------+-------+---------+
Complexity: | 9 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 38 | | OK |
--------------+---------+-------+---------+
metrics are OK
adjust (Begins at: 281 Ends at: 299)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
write_error (Begins at: 301 Ends at: 313)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__write_data (Begins at: 317 Ends at: 330)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__write_data_compressed (Begins at: 332 Ends at: 344)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
seek_random (Begins at: 348 Ends at: 360)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_file_pointer (Begins at: 364 Ends at: 369)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
convert_float (Begins at: 375 Ends at: 402)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 4 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
convert_double (Begins at: 404 Ends at: 431)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 4 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
put_fp_data (Begins at: 437 Ends at: 485)
--------------+---------+-------+---------+
Complexity: | 14 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 9 | | OK |
LOC: | 49 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
convert_int (Begins at: 491 Ends at: 537)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 1 | | OK |
LOC: | 47 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
count_bytes (Begins at: 539 Ends at: 549)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
trim_bytes (Begins at: 551 Ends at: 563)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
same (Begins at: 565 Ends at: 568)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
count_run (Begins at: 570 Ends at: 584)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
rle_compress (Begins at: 586 Ends at: 610)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
zlib_compress (Begins at: 612 Ends at: 619)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
put_data (Begins at: 623 Ends at: 702)
--------------+---------+-------+---------+
Complexity: | 14 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 13 | | OK |
LOC: | 80 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
put_raster_data (Begins at: 708 Ends at: 713)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 2 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
put_null_data (Begins at: 719 Ends at: 760)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 42 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__open_null_write (Begins at: 762 Ends at: 778)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__write_null_bits (Begins at: 780 Ends at: 801)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 7 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
convert_and_write_if (Begins at: 807 Ends at: 820)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
convert_and_write_df (Begins at: 822 Ends at: 835)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
convert_and_write_id (Begins at: 837 Ends at: 850)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
convert_and_write_fd (Begins at: 852 Ends at: 865)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
convert_and_write_fi (Begins at: 867 Ends at: 880)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
convert_and_write_di (Begins at: 882 Ends at: 895)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
put_raster_row (Begins at: 899 Ends at: 938)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 40 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 8 potentially cloned functions:
convert_and_write_di convert_and_write_fi convert_and_write_fd convert_and_write_id convert_and_write_df convert_and_write_if convert_double convert_float
In lib/gis/put_row.c clones of convert_float are:
lib/gis/put_row.c convert_double
In lib/gis/put_row.c clones of convert_and_write_if are:
lib/gis/put_row.c convert_and_write_di
lib/gis/put_row.c convert_and_write_fi
lib/gis/put_row.c convert_and_write_fd
lib/gis/put_row.c convert_and_write_id
lib/gis/put_row.c convert_and_write_df
In lib/gis/put_row.c clones of convert_and_write_df are:
lib/gis/put_row.c convert_and_write_di
lib/gis/put_row.c convert_and_write_fi
lib/gis/put_row.c convert_and_write_fd
lib/gis/put_row.c convert_and_write_id
lib/gis/put_row.c convert_and_write_if
In lib/gis/put_row.c clones of convert_and_write_fd are:
lib/gis/put_row.c convert_and_write_di
lib/gis/put_row.c convert_and_write_fi
lib/gis/put_row.c convert_and_write_id
lib/gis/put_row.c convert_and_write_df
lib/gis/put_row.c convert_and_write_if
In lib/gis/put_row.c clones of convert_double are:
lib/gis/put_row.c convert_float
In lib/gis/put_row.c clones of convert_and_write_id are:
lib/gis/put_row.c convert_and_write_di
lib/gis/put_row.c convert_and_write_fi
lib/gis/put_row.c convert_and_write_fd
lib/gis/put_row.c convert_and_write_df
lib/gis/put_row.c convert_and_write_if
In lib/gis/put_row.c clones of convert_and_write_di are:
lib/gis/put_row.c convert_and_write_fi
lib/gis/put_row.c convert_and_write_fd
lib/gis/put_row.c convert_and_write_id
lib/gis/put_row.c convert_and_write_df
lib/gis/put_row.c convert_and_write_if
In lib/gis/put_row.c clones of convert_and_write_fi are:
lib/gis/put_row.c convert_and_write_di
lib/gis/put_row.c convert_and_write_fd
lib/gis/put_row.c convert_and_write_id
lib/gis/put_row.c convert_and_write_df
lib/gis/put_row.c convert_and_write_if
__________________________________________
Threshold GRASS6 key metrics values at 2006-06-13 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 9 | 55 | 79 |
LOC: 40 | 180 | 252 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list