[GRASS-QA] SOCCER LAB GRASS QA: 1 clones ( Dscreen.c list.c get_row.c get_row.c put_row.c put_row.c vect.c areas.c draw.c position.c get_row.c pad.c main.c main.c command.c parser.c GS2.c gethead.c anim_support.c draw.c position.c site_attr_commands.c site_highlight_commands.c togl_flythrough.c parser.c raster.c line.c main.c writeascii.c ) 1 monsters and 4 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello soeren,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.out.vtk/writeascii.c functions


GetRasterValueAsDouble (Begins at: 33 Ends at: 63)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      31 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

writeVTKNormalHeader (Begins at: 69 Ends at: 95)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      11 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

writeVTKStructuredElevationHeader (Begins at: 101 Ends at: 112)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

writeVTKPolygonalElevationHeader (Begins at: 117 Ends at: 127)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

writeVTKCellDataHeader (Begins at: 132 Ends at: 136)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

writeVTKPointDataHeader (Begins at: 141 Ends at: 145)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

writeVTKStructuredCoordinates (Begins at: 152 Ends at: 198)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      13 |       |      OK |
LOC:          |      47 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

writeVTKPolygonalCoordinates (Begins at: 204 Ends at: 309)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |      23 |       |      OK |
LOC:          |     106 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

writeVTKData (Begins at: 315 Ends at: 357)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |      16 |       |      OK |
LOC:          |      43 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

writeVTKRGBImageData (Begins at: 365 Ends at: 424)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      29 |       |      OK |
LOC:          |      60 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

writeVTKVectorData (Begins at: 431 Ends at: 482)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      26 |       |      OK |
LOC:          |      52 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file has 1 potentially cloned functions:
  GetRasterValueAsDouble

In raster/r.out.vtk/writeascii.c clones of  GetRasterValueAsDouble are:
	raster3d/r3.out.vtk/writeVTKData.c  GetRasterValueAsDouble


__________________________________________

Threshold GRASS6 key metrics values at 2006-06-13 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    40 |       180 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html