[GRASS-QA] SOCCER LAB GRASS QA: 2 clones ( Dscreen.c list.c ) 0
monsters and 0 warnings
cvs at proxy.soccerlab.polymtl.ca
cvs at proxy.soccerlab.polymtl.ca
Tue Jun 13 05:58:45 EDT 2006
Hello brad,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/display/list.c functions
D_set_cell_name (Begins at: 82 Ends at: 97)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_get_cell_name (Begins at: 99 Ends at: 123)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_set_dig_name (Begins at: 125 Ends at: 140)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_get_dig_name (Begins at: 142 Ends at: 166)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_set_site_name (Begins at: 168 Ends at: 183)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_get_site_name (Begins at: 185 Ends at: 198)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_add_to_cell_list (Begins at: 200 Ends at: 203)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_get_cell_list (Begins at: 205 Ends at: 213)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_add_to_dig_list (Begins at: 215 Ends at: 218)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_get_dig_list (Begins at: 220 Ends at: 228)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_add_to_site_list (Begins at: 230 Ends at: 233)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_get_site_list (Begins at: 235 Ends at: 258)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_add_to_list (Begins at: 260 Ends at: 263)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_get_list (Begins at: 265 Ends at: 294)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_clear_window (Begins at: 296 Ends at: 309)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 10 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_claim_offset_is (Begins at: 311 Ends at: 317)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_offset_is (Begins at: 319 Ends at: 337)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_set_erase_color (Begins at: 339 Ends at: 344)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_get_erase_color (Begins at: 347 Ends at: 360)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 2 potentially cloned functions:
D_get_dig_name D_get_cell_name
In lib/display/list.c clones of D_get_cell_name are:
lib/display/list.c D_get_dig_name
In lib/display/list.c clones of D_get_dig_name are:
lib/display/list.c D_get_cell_name
__________________________________________
Threshold GRASS6 key metrics values at 2006-06-13 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 9 | 55 | 79 |
LOC: 40 | 180 | 252 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list