[GRASS-QA] SOCCER LAB GRASS QA: 4 clones ( ask.c ) 0 monsters and 3 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello hamish,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


imagery/i.vpoints/ask.c functions


ask_gis_files (Begins at: 30 Ends at: 267)
--------------+---------+-------+---------+
Complexity:   |      22 |     * |         |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      53 |     * |         |
LOC:          |     238 |    ** | Warning |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

dobox (Begins at: 269 Ends at: 290)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       5 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

uparrow (Begins at: 292 Ends at: 298)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

downarrow (Begins at: 300 Ends at: 306)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

pick (Begins at: 308 Ends at: 354)
--------------+---------+-------+---------+
Complexity:   |       9 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      13 |       |      OK |
LOC:          |      47 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

cancel_which (Begins at: 357 Ends at: 373)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      17 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

inbox (Begins at: 375 Ends at: 378)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dotext (Begins at: 380 Ends at: 392)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       7 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file has 4 potentially cloned functions:
  dobox  dotext  cancel_which  pick

In imagery/i.vpoints/ask.c clones of  cancel_which are:
	imagery/i.points/ask.c  cancel_which
	imagery/i.ortho.photo/photo.2target/ask.c  cancel_which
	imagery/i.ortho.photo/photo.2image/ask.c  cancel_which

In imagery/i.vpoints/ask.c clones of  dobox are:
	imagery/i.ortho.photo/photo.2image/ask.c  dobox
	imagery/i.ask/popup.c  dobox

In imagery/i.vpoints/ask.c clones of  pick are:
	imagery/i.points/ask.c  pick

In imagery/i.vpoints/ask.c clones of  dotext are:
	imagery/i.ortho.photo/photo.2image/ask.c  dotext


__________________________________________

Threshold GRASS6 key metrics values at 2006-06-17 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    40 |       180 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html