[GRASS-QA] SOCCER LAB GRASS QA: no clones 6 monsters and 2 warnings
cvs at proxy.soccerlab.polymtl.ca
cvs at proxy.soccerlab.polymtl.ca
Sat Jun 17 09:04:45 EDT 2006
Hello markus,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/external/shapelib/shpopen.c functions
cvsid_aw (Begins at: 201 Ends at: 201)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
SwapWord (Begins at: 231 Ends at: 250)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
SfRealloc (Begins at: 252 Ends at: 266)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
SHPWriteHeader (Begins at: 268 Ends at: 396)
--------------+---------+-------+---------+
Complexity: | 18 | * | |
ParamNBR: | 1 | | OK |
CalledNBR: | 35 | * | |
LOC: | 129 | * | |
--------------+---------+-------+---------+
metrics are OK
SHPOpen (Begins at: 399 Ends at: 636)
--------------+---------+-------+---------+
Complexity: | 21 | * | |
ParamNBR: | 2 | | OK |
CalledNBR: | 67 | ** | Warning |
LOC: | 238 | ** | Warning |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code
SHPClose (Begins at: 645 Ends at: 672)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
SHPGetInfo (Begins at: 681 Ends at: 710)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 0 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
SHPCreate (Begins at: 713 Ends at: 846)
--------------+---------+-------+---------+
Complexity: | 11 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 29 | | OK |
LOC: | 134 | * | |
--------------+---------+-------+---------+
metrics are OK
_SHPSetBounds (Begins at: 848 Ends at: 870)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
SHPComputeExtents (Begins at: 873 Ends at: 908)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 36 | | OK |
--------------+---------+-------+---------+
metrics are OK
SHPCreateObject (Begins at: 911 Ends at: 1033)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 10 | *** | MONSTER |
CalledNBR: | 11 | | OK |
LOC: | 123 | * | |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
SHPCreateSimpleObject (Begins at: 1036 Ends at: 1050)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
SHPWriteObject (Begins at: 1053 Ends at: 1428)
--------------+---------+-------+---------+
Complexity: | 47 | *** | MONSTER |
ParamNBR: | 3 | | OK |
CalledNBR: | 68 | ** | Warning |
LOC: | 376 | *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!
SHPReadObject (Begins at: 1431 Ends at: 1763)
--------------+---------+-------+---------+
Complexity: | 48 | *** | MONSTER |
ParamNBR: | 2 | | OK |
CalledNBR: | 86 | *** | MONSTER |
LOC: | 333 | *** | MONSTER |
--------------+---------+-------+---------+
3 metric are OUT OF RANGE!
SHPTypeName (Begins at: 1770 Ends at: 1820)
--------------+---------+-------+---------+
Complexity: | 17 | * | |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 51 | | OK |
--------------+---------+-------+---------+
metrics are OK
SHPPartTypeName (Begins at: 1827 Ends at: 1853)
--------------+---------+-------+---------+
Complexity: | 9 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
SHPDestroyObject (Begins at: 1860 Ends at: 1888)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
SHPRewindObject (Begins at: 1891 Ends at: 2035)
--------------+---------+-------+---------+
Complexity: | 12 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 145 | * | |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
__________________________________________
Threshold GRASS6 key metrics values at 2006-06-17 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 9 | 55 | 79 |
LOC: 40 | 180 | 252 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list