[GRASS-QA] SOCCER LAB GRASS QA: 6 clones ( Dscreen.c list.c
get_row.c get_row.c put_row.c put_row.c vect.c areas.c draw.c
position.c get_row.c pad.c main.c main.c command.c parser.c
GS2.c ) 2 monsters and 5 warnings
cvs at proxy.soccerlab.polymtl.ca
cvs at proxy.soccerlab.polymtl.ca
Tue Jun 13 05:59:04 EDT 2006
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/ogsf/GS2.c functions
void_func (Begins at: 57 Ends at: 60)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_libinit (Begins at: 63 Ends at: 94)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 32 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_longdim (Begins at: 97 Ends at: 101)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_region (Begins at: 104 Ends at: 112)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_att_defaults (Begins at: 115 Ends at: 131)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_surf_exists (Begins at: 134 Ends at: 155)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_new_surface (Begins at: 162 Ends at: 189)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_new_light (Begins at: 192 Ends at: 222)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_setlight_position (Begins at: 226 Ends at: 242)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_getlight_position (Begins at: 246 Ends at: 261)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 0 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_setlight_color (Begins at: 264 Ends at: 278)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_getlight_color (Begins at: 281 Ends at: 293)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_setlight_ambient (Begins at: 296 Ends at: 310)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_getlight_ambient (Begins at: 313 Ends at: 325)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_lights_off (Begins at: 329 Ends at: 338)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_lights_on (Begins at: 341 Ends at: 350)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_switchlight (Begins at: 353 Ends at: 364)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_transp_is_set (Begins at: 367 Ends at: 370)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_modelposition1 (Begins at: 373 Ends at: 389)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_modelposition (Begins at: 394 Ends at: 417)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_Narrow (Begins at: 425 Ends at: 486)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 62 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_X (Begins at: 490 Ends at: 521)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 32 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_line_onsurf (Begins at: 524 Ends at: 549)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 10 | | OK |
LOC: | 26 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_nline_onsurf (Begins at: 555 Ends at: 582)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 11 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
GS_draw_flowline_at_xy (Begins at: 588 Ends at: 649)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 62 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_fringe (Begins at: 654 Ends at: 661)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_legend (Begins at: 666 Ends at: 676)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 1 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
GS_draw_list (Begins at: 679 Ends at: 688)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_all_list (Begins at: 691 Ends at: 700)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_delete_list (Begins at: 703 Ends at: 709)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_lighting_model1 (Begins at: 712 Ends at: 744)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 13 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_lighting_model (Begins at: 749 Ends at: 793)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 15 | | OK |
LOC: | 45 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_update_curmask (Begins at: 799 Ends at: 805)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_is_masked (Begins at: 808 Ends at: 821)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_unset_SDsurf (Begins at: 824 Ends at: 830)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_SDsurf (Begins at: 833 Ends at: 845)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_SDscale (Begins at: 848 Ends at: 853)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_SDsurf (Begins at: 856 Ends at: 867)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_SDscale (Begins at: 870 Ends at: 875)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_update_normals (Begins at: 878 Ends at: 885)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_att (Begins at: 888 Ends at: 920)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 4 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_cat_at_xy (Begins at: 922 Ends at: 972)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 12 | | OK |
LOC: | 51 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_norm_at_xy (Begins at: 979 Ends at: 1025)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 47 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_val_at_xy (Begins at: 1033 Ends at: 1104)
--------------+---------+-------+---------+
Complexity: | 9 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 16 | | OK |
LOC: | 72 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_unset_att (Begins at: 1109 Ends at: 1117)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_att_const (Begins at: 1120 Ends at: 1131)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_maskmode (Begins at: 1135 Ends at: 1149)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_maskmode (Begins at: 1152 Ends at: 1165)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_Set_ClientData (Begins at: 1168 Ends at: 1180)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_Get_ClientData (Begins at: 1183 Ends at: 1193)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_num_surfs (Begins at: 1196 Ends at: 1199)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_surf_list (Begins at: 1203 Ends at: 1223)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_delete_surface (Begins at: 1226 Ends at: 1272)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 47 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_load_att_map (Begins at: 1274 Ends at: 1582)
--------------+---------+-------+---------+
Complexity: | 40 | *** | MONSTER |
ParamNBR: | 3 | | OK |
CalledNBR: | 66 | ** | Warning |
LOC: | 309 | *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!
GS_draw_surf (Begins at: 1585 Ends at: 1615)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_wire (Begins at: 1619 Ends at: 1636)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_alldraw_wire (Begins at: 1640 Ends at: 1652)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_alldraw_surf (Begins at: 1655 Ends at: 1664)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_exag (Begins at: 1667 Ends at: 1688)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_global_exag (Begins at: 1691 Ends at: 1710)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_global_exag (Begins at: 1713 Ends at: 1722)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_wire_color (Begins at: 1725 Ends at: 1742)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_wire_color (Begins at: 1745 Ends at: 1758)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_setall_drawmode (Begins at: 1761 Ends at: 1772)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_drawmode (Begins at: 1775 Ends at: 1794)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_drawmode (Begins at: 1797 Ends at: 1810)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_nozero (Begins at: 1813 Ends at: 1838)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 26 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_nozero (Begins at: 1841 Ends at: 1868)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_setall_drawres (Begins at: 1871 Ends at: 1882)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_drawres (Begins at: 1885 Ends at: 1913)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 1 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_drawres (Begins at: 1916 Ends at: 1936)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 1 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_dims (Begins at: 1939 Ends at: 1957)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_exag_guess (Begins at: 1963 Ends at: 2012)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 50 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_zrange_nz (Begins at: 2015 Ends at: 2039)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_trans (Begins at: 2042 Ends at: 2061)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_trans (Begins at: 2064 Ends at: 2083)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_default_draw_color (Begins at: 2087 Ends at: 2097)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_background_color (Begins at: 2100 Ends at: 2103)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_draw (Begins at: 2106 Ends at: 2130)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_ready_draw (Begins at: 2133 Ends at: 2145)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_done_draw (Begins at: 2148 Ends at: 2164)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_focus (Begins at: 2167 Ends at: 2181)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_focus_real (Begins at: 2183 Ends at: 2196)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_focus (Begins at: 2201 Ends at: 2217)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_focus_center_map (Begins at: 2220 Ends at: 2252)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_moveto (Begins at: 2255 Ends at: 2283)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_moveto_real (Begins at: 2286 Ends at: 2292)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_zextents (Begins at: 2296 Ends at: 2311)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_zrange (Begins at: 2315 Ends at: 2347)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_from (Begins at: 2350 Ends at: 2362)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_from_real (Begins at: 2365 Ends at: 2371)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_to_real (Begins at: 2374 Ends at: 2385)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_zoom_setup (Begins at: 2391 Ends at: 2404)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
GS_get_to (Begins at: 2408 Ends at: 2420)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_viewdir (Begins at: 2423 Ends at: 2428)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_viewdir (Begins at: 2432 Ends at: 2445)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_fov (Begins at: 2448 Ends at: 2453)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_fov (Begins at: 2456 Ends at: 2459)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_twist (Begins at: 2462 Ends at: 2465)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_twist (Begins at: 2469 Ends at: 2474)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_nofocus (Begins at: 2477 Ends at: 2489)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_infocus (Begins at: 2495 Ends at: 2507)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_viewport (Begins at: 2512 Ends at: 2524)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_look_here (Begins at: 2530 Ends at: 2563)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 34 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_selected_point_on_surface (Begins at: 2566 Ends at: 2627)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 12 | | OK |
LOC: | 62 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
GS_set_cplane_rot (Begins at: 2630 Ends at: 2635)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_cplane_trans (Begins at: 2638 Ends at: 2643)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_cplane (Begins at: 2647 Ends at: 2663)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_draw_cplane_fence (Begins at: 2666 Ends at: 2681)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_alldraw_cplane_fences (Begins at: 2684 Ends at: 2697)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_cplane (Begins at: 2700 Ends at: 2705)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_unset_cplane (Begins at: 2708 Ends at: 2713)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_scale (Begins at: 2716 Ends at: 2725)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_set_fencecolor (Begins at: 2728 Ends at: 2733)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_fencecolor (Begins at: 2736 Ends at: 2739)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_distance_alongsurf (Begins at: 2746 Ends at: 2764)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 4 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
GS_save_3dview (Begins at: 2767 Ends at: 2770)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_load_3dview (Begins at: 2773 Ends at: 2780)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_init_view (Begins at: 2787 Ends at: 2852)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 66 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_clear (Begins at: 2855 Ends at: 2887)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_get_aspect (Begins at: 2890 Ends at: 2912)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
GS_has_transparency (Begins at: 2914 Ends at: 2928)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 6 potentially cloned functions:
GS_get_drawmode GS_get_wire_color GS_draw_wire GS_surf_exists GS_setlight_ambient GS_setlight_color
In lib/ogsf/GS2.c clones of GS_setlight_color are:
lib/ogsf/GS2.c GS_setlight_ambient
In lib/ogsf/GS2.c clones of GS_get_drawmode are:
lib/ogsf/GVL2.c GVL_slice_get_drawmode
lib/ogsf/GVL2.c GVL_isosurf_get_drawmode
lib/ogsf/GS2.c GS_get_wire_color
In lib/ogsf/GS2.c clones of GS_setlight_ambient are:
lib/ogsf/GS2.c GS_setlight_color
In lib/ogsf/GS2.c clones of GS_surf_exists are:
lib/ogsf/GVL2.c GVL_vol_exists
lib/ogsf/GV2.c GV_vect_exists
lib/ogsf/GP2.c GP_site_exists
In lib/ogsf/GS2.c clones of GS_get_wire_color are:
lib/ogsf/GVL2.c GVL_slice_get_drawmode
lib/ogsf/GVL2.c GVL_isosurf_get_drawmode
lib/ogsf/GS2.c GS_get_drawmode
In lib/ogsf/GS2.c clones of GS_draw_wire are:
lib/ogsf/gvl.c gvl_delete_vol
lib/ogsf/gv.c gv_delete_vect
lib/ogsf/gs.c gs_delete_surf
lib/ogsf/gp.c gp_delete_site
lib/ogsf/GVL2.c GVL_draw_wire
__________________________________________
Threshold GRASS6 key metrics values at 2006-06-13 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 9 | 55 | 79 |
LOC: 40 | 180 | 252 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list