[GRASS-QA] SOCCER LAB GRASS QA: 3 clones ( colors.c ) 0 monsters and 3 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello hamish,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/imagery/colors.c functions


I_read_group_colors (Begins at: 26 Ends at: 36)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

I_read_group_red_colors (Begins at: 38 Ends at: 61)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

I_read_group_grn_colors (Begins at: 63 Ends at: 86)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

I_read_group_blu_colors (Begins at: 88 Ends at: 111)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

I_free_group_colors (Begins at: 113 Ends at: 129)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      17 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

read_color (Begins at: 131 Ends at: 149)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       4 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

get_colors (Begins at: 151 Ends at: 196)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       8 |       |      OK |
LOC:          |      46 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

build_index (Begins at: 202 Ends at: 219)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

I_write_group_colors (Begins at: 221 Ends at: 233)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

I_write_group_red_colors (Begins at: 235 Ends at: 248)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

I_write_group_grn_colors (Begins at: 250 Ends at: 262)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

I_write_group_blu_colors (Begins at: 264 Ends at: 276)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

write_colors (Begins at: 278 Ends at: 305)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       6 |       |      OK |
LOC:          |      28 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file has 3 potentially cloned functions:
  I_read_group_blu_colors  I_read_group_grn_colors  I_read_group_red_colors

In lib/imagery/colors.c clones of  I_read_group_red_colors are:
	lib/imagery/colors.c  I_read_group_blu_colors
	lib/imagery/colors.c  I_read_group_grn_colors

In lib/imagery/colors.c clones of  I_read_group_grn_colors are:
	lib/imagery/colors.c  I_read_group_blu_colors
	lib/imagery/colors.c  I_read_group_red_colors

In lib/imagery/colors.c clones of  I_read_group_blu_colors are:
	lib/imagery/colors.c  I_read_group_grn_colors
	lib/imagery/colors.c  I_read_group_red_colors


__________________________________________

Threshold GRASS6 key metrics values at 2006-05-03 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      78 |
LOC:                    40 |       182 |     256 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html