[GRASS-QA] SOCCER LAB GRASS QA: 2 clones ( main.c ) 0 monsters and 0 warnings

cvs at proxy.soccerlab.polymtl.ca cvs at proxy.soccerlab.polymtl.ca
Wed May 3 06:01:31 EDT 2006


Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.to.rast3/main.c functions


FatalError (Begins at: 48 Ends at: 67)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      20 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

SetParameters (Begins at: 72 Ends at: 89)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

RasterToG3D (Begins at: 96 Ends at: 167)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      26 |       |      OK |
LOC:          |      72 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

main (Begins at: 173 Ends at: 320)
--------------+---------+-------+---------+
Complexity:   |      16 |     * |         |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      44 |     * |         |
LOC:          |     148 |     * |         |
--------------+---------+-------+---------+
metrics are OK

OpenInputMap (Begins at: 327 Ends at: 342)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

CloseInputMap (Begins at: 347 Ends at: 351)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 2 potentially cloned functions:
  OpenInputMap  SetParameters

In raster/r.to.rast3/main.c clones of  OpenInputMap are:
	raster3d/r3.out.vtk/main.c  OpenInputMap

In raster/r.to.rast3/main.c clones of  SetParameters are:
	raster3d/base/r3.mask.main.c  setParams


__________________________________________

Threshold GRASS6 key metrics values at 2006-05-03 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      78 |
LOC:                    40 |       182 |     256 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html



More information about the grass-qa mailing list