[GRASS-QA] SOCCER LAB GRASS QA: 1 clones ( togl.c ) 2 monsters and
2 warnings
cvs at proxy.soccerlab.polymtl.ca
cvs at proxy.soccerlab.polymtl.ca
Sat May 20 09:44:47 EDT 2006
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
visualization/nviz/src/togl.c functions
AddToList (Begins at: 337 Ends at: 341)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
RemoveFromList (Begins at: 346 Ends at: 363)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
FindTogl (Begins at: 368 Ends at: 388)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_rgb_colormap (Begins at: 391 Ends at: 630)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 240 | ** | Warning |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
Togl_Init (Begins at: 632 Ends at: 650)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_CreateFunc (Begins at: 656 Ends at: 659)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_DisplayFunc (Begins at: 665 Ends at: 668)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_ReshapeFunc (Begins at: 674 Ends at: 677)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_DestroyFunc (Begins at: 683 Ends at: 686)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_TimerFunc (Begins at: 692 Ends at: 695)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_ResetDefaultCallbacks (Begins at: 701 Ends at: 710)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_SetCreateFunc (Begins at: 716 Ends at: 719)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_SetDisplayFunc (Begins at: 725 Ends at: 728)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_SetReshapeFunc (Begins at: 734 Ends at: 737)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_SetDestroyFunc (Begins at: 743 Ends at: 746)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_Timer (Begins at: 754 Ends at: 773)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_CreateCommand (Begins at: 775 Ends at: 788)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_MakeCurrent (Begins at: 790 Ends at: 813)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_Render (Begins at: 815 Ends at: 824)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
RenderOverlay (Begins at: 827 Ends at: 848)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_Configure (Begins at: 855 Ends at: 915)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 3 | | OK |
LOC: | 61 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_Widget (Begins at: 918 Ends at: 1010)
--------------+---------+-------+---------+
Complexity: | 11 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 30 | | OK |
LOC: | 93 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_Cmd (Begins at: 1012 Ends at: 1149)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 16 | | OK |
LOC: | 138 | * | |
--------------+---------+-------+---------+
metrics are OK
SetupOverlay (Begins at: 1157 Ends at: 1290)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 134 | * | |
--------------+---------+-------+---------+
metrics are OK
Togl_MakeWindowExist (Begins at: 1292 Ends at: 1785)
--------------+---------+-------+---------+
Complexity: | 40 | *** | MONSTER |
ParamNBR: | 1 | | OK |
CalledNBR: | 45 | * | |
LOC: | 494 | *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!
ToglCmdDeletedProc (Begins at: 1787 Ends at: 1838)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 52 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_Destroy (Begins at: 1840 Ends at: 1862)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_EventProc (Begins at: 1869 Ends at: 1959)
--------------+---------+-------+---------+
Complexity: | 17 | * | |
ParamNBR: | 2 | | OK |
CalledNBR: | 16 | | OK |
LOC: | 91 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_PostRedisplay (Begins at: 1963 Ends at: 1969)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_SwapBuffers (Begins at: 1973 Ends at: 1986)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_Ident (Begins at: 1990 Ends at: 1993)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_Width (Begins at: 1996 Ends at: 1999)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_Height (Begins at: 2002 Ends at: 2005)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_Interp (Begins at: 2008 Ends at: 2011)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_TkWin (Begins at: 2014 Ends at: 2032)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
noFaultXAllocColor (Begins at: 2035 Ends at: 2209)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 5 | | OK |
LOC: | 175 | * | |
--------------+---------+-------+---------+
metrics are OK
Togl_AllocColor (Begins at: 2211 Ends at: 2245)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 35 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_FreeColor (Begins at: 2249 Ends at: 2267)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_SetColor (Begins at: 2271 Ends at: 2323)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 3 | | OK |
LOC: | 53 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_LoadBitmapFont (Begins at: 2335 Ends at: 2443)
--------------+---------+-------+---------+
Complexity: | 13 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 109 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_UnloadBitmapFont (Begins at: 2450 Ends at: 2461)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_UseLayer (Begins at: 2469 Ends at: 2506)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 38 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_ShowOverlay (Begins at: 2511 Ends at: 2518)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_HideOverlay (Begins at: 2523 Ends at: 2529)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_PostOverlayRedisplay (Begins at: 2533 Ends at: 2540)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_OverlayDisplayFunc (Begins at: 2543 Ends at: 2546)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_ExistsOverlay (Begins at: 2549 Ends at: 2552)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_GetOverlayTransparentValue (Begins at: 2555 Ends at: 2558)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_IsMappedOverlay (Begins at: 2561 Ends at: 2564)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_AllocColorOverlay (Begins at: 2568 Ends at: 2583)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_FreeColorOverlay (Begins at: 2586 Ends at: 2600)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_ClientData (Begins at: 2602 Ends at: 2605)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_GetClientData (Begins at: 2608 Ends at: 2611)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_SetClientData (Begins at: 2614 Ends at: 2624)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_Display (Begins at: 2626 Ends at: 2629)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_Screen (Begins at: 2631 Ends at: 2634)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_ScreenNumber (Begins at: 2636 Ends at: 2639)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Togl_Colormap (Begins at: 2641 Ends at: 2735)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 95 | | OK |
--------------+---------+-------+---------+
metrics are OK
grabPixels (Begins at: 2737 Ends at: 2788)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 20 | | OK |
LOC: | 52 | | OK |
--------------+---------+-------+---------+
metrics are OK
generateEPS (Begins at: 2791 Ends at: 2908)
--------------+---------+-------+---------+
Complexity: | 25 | * | |
ParamNBR: | 4 | | OK |
CalledNBR: | 44 | * | |
LOC: | 118 | * | |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
Togl_DumpToEpsFile (Begins at: 2914 Ends at: 2990)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 8 | | OK |
LOC: | 77 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
unload_font
In visualization/nviz/src/togl_cb.c clones of unload_font are:
visualization/nviz/src/change_view.c Nchange_twist_cmd
__________________________________________
Threshold GRASS6 key metrics values at 2006-05-20 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 36 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 9 | 55 | 79 |
LOC: 40 | 182 | 253 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list