[GRASS-QA] GRASS QA: hamish | ./grass6/raster/r.resamp.stats/main.c |1 clones ( main.c )| 0 monsters | 1 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello hamish,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.resamp.stats/main.c functions


build_method_list (Begins at: 28 Ends at: 45)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

find_method (Begins at: 47 Ends at: 56)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

resamp_unweighted (Begins at: 66 Ends at: 138)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      18 |       |      OK |
LOC:          |      73 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

resamp_weighted (Begins at: 140 Ends at: 229)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      20 |       |      OK |
LOC:          |      90 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

main (Begins at: 231 Ends at: 370)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      68 |    ** | Warning |
LOC:          |     140 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file has 1 potentially cloned functions:
  build_method_list

In raster/r.resamp.stats/main.c clones of  build_method_list are:
	raster/r.series/main.c  build_method_list


__________________________________________

Threshold GRASS6 key metrics values at 2006-11-14 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      85 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html