[GRASS-QA] GRASS QA: hamish | ./grass6/display/d.grid/plot.c |no clones | 0 monsters | 2 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello hamish,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


display/d.grid/plot.c functions


plot_grid (Begins at: 13 Ends at: 102)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      36 |     * |         |
LOC:          |      90 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

plot_geogrid (Begins at: 105 Ends at: 227)
--------------+---------+-------+---------+
Complexity:   |      11 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      49 |     * |         |
LOC:          |     123 |     * |         |
--------------+---------+-------+---------+
metrics are OK

init_proj (Begins at: 233 Ends at: 289)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      25 |       |      OK |
LOC:          |      57 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

get_ll_bounds (Begins at: 295 Ends at: 390)
--------------+---------+-------+---------+
Complexity:   |      13 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      12 |       |      OK |
LOC:          |      96 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

check_coords (Begins at: 397 Ends at: 462)
--------------+---------+-------+---------+
Complexity:   |      13 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |      15 |       |      OK |
LOC:          |      66 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

get_heading (Begins at: 469 Ends at: 500)
--------------+---------+-------+---------+
Complexity:   |       9 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      32 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-11-18 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html