[GRASS-QA] GRASS QA: hamish | ./grass6/raster/r.sun/main.c |no clones | 3 monsters | 3 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Sat Nov 18 10:02:17 EST 2006



Hello hamish,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.sun/main.c functions


main (Begins at: 132 Ends at: 470)
--------------+---------+-------+---------+
Complexity:   |      24 |     * |         |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |     111 |   *** | MONSTER |
LOC:          |     339 |   *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!

INPUT (Begins at: 473 Ends at: 692)
--------------+---------+-------+---------+
Complexity:   |      45 |   *** | MONSTER |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      81 |    ** | Warning |
LOC:          |     220 |    ** | Warning |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

OUTGR (Begins at: 694 Ends at: 824)
--------------+---------+-------+---------+
Complexity:   |      29 |    ** | Warning |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      50 |     * |         |
LOC:          |     131 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

com_par_const (Begins at: 827 Ends at: 864)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      38 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

com_par (Begins at: 867 Ends at: 938)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      13 |       |      OK |
LOC:          |      72 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

lumcline2 (Begins at: 942 Ends at: 980)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      39 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

joules2 (Begins at: 982 Ends at: 1112)
--------------+---------+-------+---------+
Complexity:   |      22 |     * |         |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      11 |       |      OK |
LOC:          |     131 |     * |         |
--------------+---------+-------+---------+
metrics are OK

new_point (Begins at: 1117 Ends at: 1126)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

where_is_point (Begins at: 1128 Ends at: 1153)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      26 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

cube (Begins at: 1155 Ends at: 1160)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

searching (Begins at: 1162 Ends at: 1188)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

calculate (Begins at: 1194 Ends at: 1431)
--------------+---------+-------+---------+
Complexity:   |      29 |    ** | Warning |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      53 |     * |         |
LOC:          |     238 |    ** | Warning |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code

com_sol_const (Begins at: 1433 Ends at: 1442)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

com_declin (Begins at: 1445 Ends at: 1455)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

brad (Begins at: 1457 Ends at: 1484)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      28 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

drad (Begins at: 1486 Ends at: 1540)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      55 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

test (Begins at: 1542 Ends at: 1556)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-11-18 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list