[GRASS-QA] GRASS QA: hamish | ./grass6/lib/vector/Vlib/map.c |no clones | 0 monsters | 1 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello hamish,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/vector/Vlib/map.c functions


Vect_copy_map_lines (Begins at: 37 Ends at: 85)
--------------+---------+-------+---------+
Complexity:   |       9 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      15 |       |      OK |
LOC:          |      49 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

copy_file (Begins at: 92 Ends at: 132)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |      41 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_copy (Begins at: 135 Ends at: 254)
--------------+---------+-------+---------+
Complexity:   |      13 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      51 |     * |         |
LOC:          |     120 |     * |         |
--------------+---------+-------+---------+
metrics are OK

Vect_rename (Begins at: 257 Ends at: 363)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      44 |     * |         |
LOC:          |     107 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_delete (Begins at: 372 Ends at: 489)
--------------+---------+-------+---------+
Complexity:   |      15 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      55 |     * |         |
LOC:          |     118 |     * |         |
--------------+---------+-------+---------+
metrics are OK

Vect_copy_tables (Begins at: 498 Ends at: 559)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      17 |       |      OK |
LOC:          |      62 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_copy_table (Begins at: 562 Ends at: 580)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_copy_table_by_cats (Begins at: 583 Ends at: 624)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |      10 |       |      OK |
LOC:          |      42 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Vect_set_release_support (Begins at: 632 Ends at: 642)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_set_category_index_update (Begins at: 645 Ends at: 648)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-10-02 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      81 |
LOC:                    40 |       182 |     253 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html