[GRASS-QA] GRASS QA: hamish | ./grass6/raster/r.le/r.le.patch/patch.c |no clones | 4 monsters | 3 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Wed Oct 11 05:10:42 EDT 2006



Hello hamish,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.le/r.le.patch/patch.c functions


df_patch (Begins at: 41 Ends at: 301)
--------------+---------+-------+---------+
Complexity:   |      67 |   *** | MONSTER |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |     106 |   *** | MONSTER |
LOC:          |     261 |    ** | Warning |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!

df_att (Begins at: 309 Ends at: 348)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      40 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

save_att (Begins at: 356 Ends at: 431)
--------------+---------+-------+---------+
Complexity:   |       9 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |      10 |       |      OK |
LOC:          |      76 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

df_core (Begins at: 439 Ends at: 552)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      23 |       |      OK |
LOC:          |     114 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

save_core (Begins at: 554 Ends at: 687)
--------------+---------+-------+---------+
Complexity:   |      16 |     * |         |
ParamNBR:     |      13 |   *** | MONSTER |
CalledNBR:    |      23 |       |      OK |
LOC:          |     134 |     * |         |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

df_size (Begins at: 695 Ends at: 774)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      12 |       |      OK |
LOC:          |      80 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

save_size (Begins at: 776 Ends at: 876)
--------------+---------+-------+---------+
Complexity:   |      11 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      13 |       |      OK |
LOC:          |     101 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

df_shape (Begins at: 878 Ends at: 1044)
--------------+---------+-------+---------+
Complexity:   |      20 |     * |         |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      37 |     * |         |
LOC:          |     167 |     * |         |
--------------+---------+-------+---------+
metrics are OK

save_shape (Begins at: 1046 Ends at: 1292)
--------------+---------+-------+---------+
Complexity:   |      30 |    ** | Warning |
ParamNBR:     |      19 |   *** | MONSTER |
CalledNBR:    |      36 |     * |         |
LOC:          |     247 |    ** | Warning |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

df_boundary (Begins at: 1294 Ends at: 1355)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      62 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

df_perim (Begins at: 1357 Ends at: 1462)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      13 |       |      OK |
LOC:          |     106 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

mv_patch (Begins at: 1464 Ends at: 1510)
--------------+---------+-------+---------+
Complexity:   |      11 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |      47 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

recl_coh (Begins at: 1512 Ends at: 1535)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

in_group (Begins at: 1537 Ends at: 1593)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      57 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

index_coh (Begins at: 1595 Ends at: 1620)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      26 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

m_att (Begins at: 1622 Ends at: 1753)
--------------+---------+-------+---------+
Complexity:   |      21 |     * |         |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |     132 |     * |         |
--------------+---------+-------+---------+
metrics are OK

m_size (Begins at: 1760 Ends at: 1888)
--------------+---------+-------+---------+
Complexity:   |      19 |     * |         |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |     129 |     * |         |
--------------+---------+-------+---------+
metrics are OK

m_core (Begins at: 1890 Ends at: 2074)
--------------+---------+-------+---------+
Complexity:   |      32 |    ** | Warning |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |     185 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

m_shape (Begins at: 2076 Ends at: 2209)
--------------+---------+-------+---------+
Complexity:   |      24 |     * |         |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |     134 |     * |         |
--------------+---------+-------+---------+
metrics are OK

m_boundary (Begins at: 2211 Ends at: 2294)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      84 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

m_perim (Begins at: 2296 Ends at: 2386)
--------------+---------+-------+---------+
Complexity:   |      16 |     * |         |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      91 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

eu_d (Begins at: 2390 Ends at: 2394)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-10-11 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      85 |
LOC:                    41 |       189 |     264 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list